Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: add a missing space in node_os.cc #10931

Closed
wants to merge 1 commit into from
Closed

src: add a missing space in node_os.cc #10931

wants to merge 1 commit into from

Conversation

aqrln
Copy link
Contributor

@aqrln aqrln commented Jan 21, 2017

This PR makes a small stylistic fix adding a missing space in GetOSType function in node_os.cc.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

src

@aqrln
src: add a missing space in node_os.cc
360b860 
This commit makes a small stylistic fix adding a missing space in
GetOSType function in node_os.cc
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. os Issues and PRs related to the os subsystem. lts-watch-v6.x labels Jan 21, 2017
@addaleax
Copy link
Member

CI: https://ci.nodejs.org/job/node-test-commit/7389/

@aqrln
Copy link
Contributor Author

aqrln commented Jan 21, 2017

@addaleax the errors on Windows are really weird. Maybe rerun it? Though it would really be an achievement to break a build with a space character in C++ source.

@addaleax
Copy link
Member

Yea, that kind of CI weirdness is something that just happens occasionally, I think we can feel pretty confident about filing that under “not related to this PR” ;)

jasnell pushed a commit that referenced this pull request Jan 23, 2017
@aqrln @jasnell
src: add a missing space in node_os.cc
c8c79b9 
This commit makes a small stylistic fix adding a missing space in
GetOSType function in node_os.cc

PR-URL: #10931
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michal Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell
Copy link
Member

jasnell commented Jan 23, 2017

Landed in c8c79b9

@jasnell jasnell closed this Jan 23, 2017
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 25, 2017
@aqrln @italoacasas
src: add a missing space in node_os.cc
028bfc6 
This commit makes a small stylistic fix adding a missing space in
GetOSType function in node_os.cc

PR-URL: nodejs#10931
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michal Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@italoacasas italoacasas mentioned this pull request Jan 25, 2017
Closed
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 27, 2017
@aqrln @italoacasas
src: add a missing space in node_os.cc
0b66adb 
This commit makes a small stylistic fix adding a missing space in
GetOSType function in node_os.cc

PR-URL: nodejs#10931
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michal Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@italoacasas italoacasas mentioned this pull request Jan 29, 2017
Merged
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 30, 2017
@aqrln @italoacasas
src: add a missing space in node_os.cc
0c0334f 
This commit makes a small stylistic fix adding a missing space in
GetOSType function in node_os.cc

PR-URL: nodejs#10931
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michal Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 30, 2017
@aqrln @italoacasas
src: add a missing space in node_os.cc
b2c0cf0 
This commit makes a small stylistic fix adding a missing space in
GetOSType function in node_os.cc

PR-URL: nodejs#10931
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michal Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 8, 2017
@aqrln @MylesBorins
src: add a missing space in node_os.cc
de1faeb 
This commit makes a small stylistic fix adding a missing space in
GetOSType function in node_os.cc

PR-URL: #10931
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michal Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 8, 2017
@aqrln @MylesBorins
src: add a missing space in node_os.cc
3eada26 
This commit makes a small stylistic fix adding a missing space in
GetOSType function in node_os.cc

PR-URL: #10931
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michal Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 9, 2017
@aqrln @MylesBorins
src: add a missing space in node_os.cc
c7436df 
This commit makes a small stylistic fix adding a missing space in
GetOSType function in node_os.cc

PR-URL: #10931
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michal Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Mar 9, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Mar 9, 2017
@aqrln @MylesBorins
src: add a missing space in node_os.cc
90d8e11 
This commit makes a small stylistic fix adding a missing space in
GetOSType function in node_os.cc

PR-URL: #10931
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michal Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Mar 9, 2017
Merged
@aqrln aqrln deleted the src-node-os-stylefix branch March 10, 2017 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

@targos targos targos approved these changes

@cjihrig cjihrig cjihrig approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. os Issues and PRs related to the os subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@aqrln @addaleax @jasnell @targos @cjihrig @MylesBorins @nodejs-github-bot