test: test-assert.js add 2nd argument to throws

[Marlena]

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• commit message follows commit guidelines

Affected core subsystem(s)

test

[cjihrig]

Why add the g?

[Marlena]

regexp.lastIndex requires that /g be used with a regular expression. See the description section of lastIndex on mdn: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/RegExp/lastIndex LastIndex is called for the block on line 106. In order for the regex supplied to makeBlock to match, it needs a /g.

…

On Sat, Jan 28, 2017 at 4:56 PM, Colin Ihrig ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In test/parallel/test-assert.js <#11061 (review)>: > @@ -102,9 +102,11 @@ assert.throws(makeBlock(a.deepEqual, /a/igm, /a/im), /^AssertionError: \/a\/gim deepEqual \/a\/im$/); { - const re1 = /a/; + const re1 = /a/g; Why add the g? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#11061 (review)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAVBCgPzSthb7fKIDHQPDSSZFbEohTQKks5rW-PJgaJpZM4LwqUQ> .

[cjihrig]

Thanks for the link. It looks like the test can technically pass without adding the g flag, but I agree it should be included.

[Trott]

Nit: You don't need to make the change I'm about to suggest, but the assert.throws() on line 241 (in the current version of the test, line 243 in the version of the file in this PR) is very similar. I think it's identical except that it is testing deepStrictEqual() instead of deepEqual(). Want to add the RegExp and the /g there as well?

[jasnell]

CI: https://ci.nodejs.org/job/node-test-pull-request/6109/

[Trott]

Only CI failure is a known-flaky documented at #11041. So CI looks good.

[Trott]

Landed in 262400f.
Thanks for the contribution! 🎉

[Marlena]

Yay!!!!

…

On Tue, Jan 31, 2017 at 11:56 AM Rich Trott ***@***.***> wrote: Closed #11061 <#11061>. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#11061 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAVBClFifPL3jl7_obnGqTEB-A3ojo1zks5rX5IHgaJpZM4LwqUQ> .