Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add abouthiroppy to collaborators #11080

Conversation

hiroppy
Copy link
Member

@hiroppy hiroppy commented Jan 31, 2017

Add @abouthiroppy as collaborators to README.md.

Checklist
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Jan 31, 2017
@hiroppy hiroppy force-pushed the feature/add-abouthiroppy-to-collaborator branch from bb43422 to 8c6947f Compare January 31, 2017 13:39
@hiroppy
Copy link
Member Author

hiroppy commented Jan 31, 2017

Copy link
Contributor

@evanlucas evanlucas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Welcome aboard!

hiroppy added a commit that referenced this pull request Jan 31, 2017
PR-URL: #11080
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
@hiroppy
Copy link
Member Author

hiroppy commented Jan 31, 2017

Landed in 04da44a.
Thanks, all :)

@hiroppy hiroppy closed this Jan 31, 2017
@hiroppy hiroppy deleted the feature/add-abouthiroppy-to-collaborator branch January 31, 2017 14:11
Copy link
Member

@gibfahn gibfahn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Belated LGTM

evanlucas pushed a commit that referenced this pull request Jan 31, 2017
PR-URL: #11080
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
@italoacasas italoacasas mentioned this pull request Jan 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants