test: increase dgram ref()/unref() coverage #11240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc: @nodejs/testing |
santigimeno
reviewed
Feb 10, 2017
| { | ||
| // Test the case of unref()'ing a socket with a handle. | ||
| const s = dgram.createSocket('udp4'); | ||
| s.bind(); |
There was a problem hiding this comment.
Is the call to bind() necessary?
There was a problem hiding this comment.
The test will run without the bind(), but binding keeps the event loop open and causes the test to timeout if unref'ing doesn't actually work.
jasnell
approved these changes
Feb 10, 2017
This commit completes code coverage for dgram's Socket#ref() and Socket#unref() methods. PR-URL: nodejs#11240 Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
italoacasas
pushed a commit
that referenced
this pull request
Feb 13, 2017
This commit completes code coverage for dgram's Socket#ref() and Socket#unref() methods. PR-URL: #11240 Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Feb 14, 2017
This commit completes code coverage for dgram's Socket#ref() and Socket#unref() methods. PR-URL: nodejs#11240 Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
krydos
pushed a commit
to krydos/node
that referenced
this pull request
Feb 25, 2017
This commit completes code coverage for dgram's Socket#ref() and Socket#unref() methods. PR-URL: nodejs#11240 Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
|
Landing on v6. Needs a backport PR if it should land on v4 |
jasnell
pushed a commit
that referenced
this pull request
Mar 8, 2017
This commit completes code coverage for dgram's Socket#ref() and Socket#unref() methods. PR-URL: #11240 Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 9, 2017
This commit completes code coverage for dgram's Socket#ref() and Socket#unref() methods. PR-URL: #11240 Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit completes code coverage for
dgram'sSocket#ref()andSocket#unref()methods.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test