Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add coverage for string array dgram send() #11247

Merged
merged 1 commit into from
Feb 10, 2017

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Feb 8, 2017

This commit adds code coverage for dgram's Socket#send() where the data is an array of strings.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Feb 8, 2017
@mscdex mscdex added the dgram Issues and PRs related to the dgram subsystem / UDP. label Feb 8, 2017
Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I'm curious: do we / should we test arrays of other data types also?

@cjihrig
Copy link
Contributor Author

cjihrig commented Feb 9, 2017

do we / should we test arrays of other data types also?

Yea, that code is already covered.

@cjihrig
Copy link
Contributor Author

cjihrig commented Feb 9, 2017

Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This commit adds code coverage for dgram's Socket#send() where
the data is an array of strings.

PR-URL: nodejs#11247
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@cjihrig cjihrig merged commit df14956 into nodejs:master Feb 10, 2017
@cjihrig cjihrig deleted the string-array branch February 10, 2017 20:39
italoacasas pushed a commit that referenced this pull request Feb 13, 2017
This commit adds code coverage for dgram's Socket#send() where
the data is an array of strings.

PR-URL: #11247
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Feb 14, 2017
This commit adds code coverage for dgram's Socket#send() where
the data is an array of strings.

PR-URL: nodejs#11247
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
krydos pushed a commit to krydos/node that referenced this pull request Feb 25, 2017
This commit adds code coverage for dgram's Socket#send() where
the data is an array of strings.

PR-URL: nodejs#11247
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
jasnell pushed a commit that referenced this pull request Mar 7, 2017
This commit adds code coverage for dgram's Socket#send() where
the data is an array of strings.

PR-URL: #11247
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
MylesBorins pushed a commit that referenced this pull request Mar 9, 2017
This commit adds code coverage for dgram's Socket#send() where
the data is an array of strings.

PR-URL: #11247
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@MylesBorins MylesBorins mentioned this pull request Mar 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dgram Issues and PRs related to the dgram subsystem / UDP. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants