Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: cover dgram socket close during bind case #11383

Merged
merged 1 commit into from
Feb 16, 2017

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Feb 14, 2017

This commit tests the scenario where a dgram socket closes during a call to Socket#bind().

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Feb 14, 2017
@cjihrig cjihrig added the dgram Issues and PRs related to the dgram subsystem / UDP. label Feb 14, 2017
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@targos
Copy link
Member

targos commented Feb 15, 2017

This commit tests the scenario where a dgram socket closes
during a call to Socket#bind().

PR-URL: nodejs#11383
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@cjihrig cjihrig merged commit a196895 into nodejs:master Feb 16, 2017
@cjihrig cjihrig deleted the close-during-bind branch February 16, 2017 18:12
italoacasas pushed a commit to italoacasas/node that referenced this pull request Feb 20, 2017
This commit tests the scenario where a dgram socket closes
during a call to Socket#bind().

PR-URL: nodejs#11383
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
italoacasas pushed a commit that referenced this pull request Feb 22, 2017
This commit tests the scenario where a dgram socket closes
during a call to Socket#bind().

PR-URL: #11383
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@italoacasas italoacasas mentioned this pull request Feb 25, 2017
@jasnell
Copy link
Member

jasnell commented Mar 7, 2017

Requires the common.mustNotCall() function to be backported to v6 and v4 before this can be backported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dgram Issues and PRs related to the dgram subsystem / UDP. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants