Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

util: eliminate unnecessary exports #11451

Closed
wants to merge 1 commit into from

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Feb 18, 2017

The getHiddenValue and setHiddenValue functions are exported from internalUtil for no really good reason

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

internal util

The getHiddenValue and setHiddenValue functions
are exported from internalUtil for no really good
reason
@nodejs-github-bot nodejs-github-bot added the util Issues and PRs related to the built-in util module. label Feb 18, 2017
@jasnell
Copy link
Member Author

jasnell commented Feb 18, 2017

jasnell added a commit that referenced this pull request Feb 19, 2017
The getHiddenValue and setHiddenValue functions
are exported from internalUtil for no really good
reason

PR-URL: #11451
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@jasnell
Copy link
Member Author

jasnell commented Feb 19, 2017

Landed in b855dad

@jasnell jasnell closed this Feb 19, 2017
addaleax pushed a commit that referenced this pull request Feb 22, 2017
The getHiddenValue and setHiddenValue functions
are exported from internalUtil for no really good
reason

PR-URL: #11451
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@italoacasas italoacasas mentioned this pull request Feb 25, 2017
@jasnell
Copy link
Member Author

jasnell commented Mar 7, 2017

needs a backport PR to land in v4 or v6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
util Issues and PRs related to the built-in util module.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants