Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

benchmark: remove v8ForceOptimization calls #11908

Closed
wants to merge 1 commit into from
Closed

benchmark: remove v8ForceOptimization calls #11908

wants to merge 1 commit into from

Conversation

lucaslago
Copy link
Contributor

@lucaslago lucaslago commented Mar 17, 2017 •
edited
Loading

#9615 removed common.v8ForceOptimization along with most of the calls to it but these were left behind. This removes common.v8ForceOptimization calls from url and vm benchmark
files.

Fixes: #11895

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

benchmark

@lucaslago
benchmark: remove v8ForceOptimization calls
cda921e 
This removes common.v8ForceOptimization calls from url and vm benchmark
files.

Fixes: nodejs#11895
@nodejs-github-bot nodejs-github-bot added the benchmark Issues and PRs related to the benchmark subsystem. label Mar 17, 2017
@mscdex mscdex added whatwg-url Issues and PRs related to the WHATWG URL implementation. vm Issues and PRs related to the vm subsystem. labels Mar 17, 2017
@TimothyGu
Copy link
Member

TimothyGu commented Mar 17, 2017 •
edited
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/6910/

CI: https://ci.nodejs.org/job/node-test-linter/7679/

TimothyGu
TimothyGu approved these changes Mar 17, 2017
View reviewed changes
Copy link
Member

@TimothyGu TimothyGu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@lucaslago
Copy link
Contributor Author

It seems some CI checks failed because some jobs were aborted, is that normal?

@TimothyGu
Copy link
Member

@lucaslago, yes unfortunately.

@TimothyGu
Copy link
Member

@lucaslago actually it was a human error. I intentionally stopped the CI tasks when I realized that the only task that really matters for this PR is the linter (we don't have regression tests for benchmarks), but seems like the GitHub integration returns an error when the task is stopped...

@lucaslago
Copy link
Contributor Author

@TimothyGu that makes sense, thanks for clarifying! :)

@targos targos self-assigned this Mar 21, 2017
targos pushed a commit to targos/node that referenced this pull request Mar 21, 2017
@lucaslago @targos
benchmark: remove v8ForceOptimization calls
3129ba2 
This removes common.v8ForceOptimization calls from url and vm benchmark
files.

PR-URL: nodejs#11908
Fixes: nodejs#11895
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@targos
Copy link
Member

targos commented Mar 21, 2017

Landed in 3129ba2. Thank you!

@targos targos closed this Mar 21, 2017
jungx098 pushed a commit to jungx098/node that referenced this pull request Mar 21, 2017
@lucaslago @jungx098
benchmark: remove v8ForceOptimization calls
4bff6b8 
This removes common.v8ForceOptimization calls from url and vm benchmark
files.

PR-URL: nodejs#11908
Fixes: nodejs#11895
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 28, 2017
@lucaslago @MylesBorins
benchmark: remove v8ForceOptimization calls
85eb1bc 
This removes common.v8ForceOptimization calls from url and vm benchmark
files.

PR-URL: #11908
Fixes: #11895
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@MylesBorins MylesBorins mentioned this pull request Mar 28, 2017
Merged
@italoacasas italoacasas mentioned this pull request Apr 10, 2017
Merged
2 tasks
@piascikj piascikj mentioned this pull request Oct 3, 2017
Open
@targos targos removed their assignment Oct 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

@TimothyGu TimothyGu TimothyGu approved these changes

@targos targos targos approved these changes

Assignees
No one assigned
Labels
benchmark Issues and PRs related to the benchmark subsystem. vm Issues and PRs related to the vm subsystem. whatwg-url Issues and PRs related to the WHATWG URL implementation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

vm benchmarks are broken
8 participants
@lucaslago @TimothyGu @targos @jasnell @lpinca @mscdex @MylesBorins @nodejs-github-bot