http: avoid retaining unneeded memory #11926

lpinca · 2017-03-19T20:11:59Z

Prevents the events listeners of the sockets obtained with the HTTP upgrade mechanism from retaining unneeded objects like state.

Reduces memory usage by ~20%.

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
commit message follows commit guidelines

Affected core subsystem(s)

lpinca · 2017-03-19T20:21:17Z

lib/_http_server.js

@@ -475,6 +473,7 @@ function onParserExecuteCommon(server, socket, parser, state, ret, d) {
    socket.removeListener('data', state.onData);
    socket.removeListener('end', state.onEnd);
    socket.removeListener('close', state.onClose);
+    socket.removeAllListeners('drain');


I'm not sure if this is ok but there are 2 listeners for the drain event and both seem to be useless for upgrade requests.
The first checks if _httpMessage is set and this is never true for upgrade requests.
The second checks if the socket is _paused but unless I'm missing something this flag is never set for upgrade requests.

.removeAllListeners() also removes any user-installed 'drain' event listeners so no, probably not a good idea.

Yeah I get that but can a user add a listener for the drain event before this is called?

Yes, server.on('connection', c => c.on('drain', ondrain)).

jasnell · 2017-03-20T17:20:53Z

/cc @nodejs/http

cjihrig

LGTM pending CI

lpinca · 2017-03-20T17:41:08Z

Refs: #11868

bnoordhuis · 2017-03-20T17:49:53Z

lib/_http_server.js

@@ -475,6 +473,7 @@ function onParserExecuteCommon(server, socket, parser, state, ret, d) {
    socket.removeListener('data', state.onData);
    socket.removeListener('end', state.onEnd);
    socket.removeListener('close', state.onClose);
+    socket.removeAllListeners('drain');


.removeAllListeners() also removes any user-installed 'drain' event listeners so no, probably not a good idea.

lpinca · 2017-03-20T19:18:10Z

@bnoordhuis updated, PTAL.
This listener is no longer removed as I can't find a clean way to selectively remove it without exporting the function.

bnoordhuis · 2017-03-20T19:38:11Z

@lpinca You could move it to lib/internal/http.js.

lpinca · 2017-03-20T20:05:54Z

Done, thanks.

bnoordhuis · 2017-03-20T20:09:29Z

lib/internal/http.js

 module.exports = {
-  outHeadersKey: Symbol('outHeadersKey')
+  outHeadersKey: Symbol('outHeadersKey'),
+  ondrain


I'd add a comma, saves one line in the diff next time someone adds a property.

jasnell · 2017-03-22T04:56:48Z

CI: https://ci.nodejs.org/job/node-test-pull-request/6968/

jasnell · 2017-03-22T16:37:27Z

@lpinca ... this is not landing cleanly for some reason (even tho it shows zero conflicts...) can you please squash the commits, rebase, and I'll try again.

Prevent the events listeners of the sockets obtained with the HTTP upgrade mechanism from retaining unneeded memory. Refs: nodejs#11868

lpinca · 2017-03-22T17:15:43Z

@jasnell done.

Prevent the events listeners of the sockets obtained with the HTTP upgrade mechanism from retaining unneeded memory. Ref: #11868 PR-URL: #11926 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

jasnell · 2017-03-22T17:32:10Z

Landed in e0a9ad1

MylesBorins · 2017-03-28T22:28:20Z

This will need to be manually backported to v7.x

Prevent the events listeners of the sockets obtained with the HTTP upgrade mechanism from retaining unneeded memory. Ref: nodejs#11868 PR-URL: nodejs#11926 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

MylesBorins · 2017-04-10T22:31:28Z

Looks like this change is breaking spdy. Example breakage from spdy tests.

  6) SPDY Server spdy/3 plain mode should not crash on .writeHead() after socket close:
     Uncaught TypeError: Cannot read property 'emit' of null
      at Socket.socketOnError (_http_server.js:450:19)
      at Stream.onStreamError (lib/spdy/handle.js:110:18)
      at node_modules/spdy-transport/lib/spdy-transport/connection.js:749:12
      at Array.forEach (native)
      at Connection.destroyStreams (node_modules/spdy-transport/lib/spdy-transport/connection.js:745:33)
      at Socket.onclose (node_modules/spdy-transport/lib/spdy-transport/connection.js:185:10)
      at TCP._handle.close [as _onclose] (net.js:534:12)

ronkorving · 2017-04-11T02:59:09Z

@indutny Any chance this could be solved on the spdy side of things?

bnoordhuis · 2017-04-11T08:33:28Z

Removing the backport-to-v7.x label and adding dont-land-on labels until this is resolved.

lpinca · 2017-04-11T08:37:32Z

Not sure if the following is the proper way to fix the issue but it seems to work:

diff --git a/lib/spdy/server.js b/lib/spdy/server.js
index 777f682..d5321c2 100644
--- a/lib/spdy/server.js
+++ b/lib/spdy/server.js
@@ -189,6 +189,8 @@ proto._onStream = function _onStream (stream) {
     socket = new net.Socket(socketOptions)
   }
 
+  socket.server = this;
+
   handle.assignSocket(socket)
 
   // For v0.8

Will send a PR.

lpinca · 2017-04-11T19:37:12Z

That patch seems to not work on Node.js 0.10 and 0.12.

The problem is that node-spdy calls the connectionListener on a new socket for which the server property is null.

Fixes a regression that caused an error to be thrown when trying to emit the 'timeout' event on the server referenced by `socket.server`. Fixes: nodejs#13435 Refs: nodejs#11926

Fixes a regression that caused an error to be thrown when trying to emit the 'timeout' event on the server referenced by `socket.server`. Fixes: #13435 Refs: #11926 PR-URL: #13578 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

nodejs-github-bot added the http Issues or PRs related to the http subsystem. label Mar 19, 2017

lpinca commented Mar 19, 2017

View reviewed changes

lpinca force-pushed the free/unneeded-memory branch from 4b1709a to 5c2d743 Compare March 20, 2017 07:33

jasnell approved these changes Mar 20, 2017

View reviewed changes

cjihrig approved these changes Mar 20, 2017

View reviewed changes

bnoordhuis requested changes Mar 20, 2017

View reviewed changes

lpinca force-pushed the free/unneeded-memory branch from 5c2d743 to b435591 Compare March 20, 2017 19:04

bnoordhuis approved these changes Mar 20, 2017

View reviewed changes

lpinca force-pushed the free/unneeded-memory branch from 295bd86 to 76b237b Compare March 20, 2017 20:17

http: avoid retaining unneeded memory

0100984

Prevent the events listeners of the sockets obtained with the HTTP upgrade mechanism from retaining unneeded memory. Refs: nodejs#11868

lpinca force-pushed the free/unneeded-memory branch from 76b237b to 0100984 Compare March 22, 2017 17:15

jasnell closed this Mar 22, 2017

lpinca deleted the free/unneeded-memory branch March 22, 2017 17:34

lpinca mentioned this pull request Mar 25, 2017

High memory usage for upgraded http requests #11868

Closed

MylesBorins added the backport-to-v7.x label Mar 28, 2017

lpinca mentioned this pull request Mar 29, 2017

v7.x backport: http: avoid retaining unneeded memory #12112

Closed

jasnell mentioned this pull request Apr 4, 2017

8.0.0 Release Proposal #12220

Closed

MylesBorins mentioned this pull request Apr 10, 2017

NodeJS 8 support spdy-http2/node-spdy#308

Closed

bnoordhuis added dont-land-on-v4.x and removed backport-to-v7.x labels Apr 11, 2017

lpinca mentioned this pull request Apr 11, 2017

Fix compatibility with Node.js master spdy-http2/node-spdy#309

Closed

lpinca mentioned this pull request Apr 12, 2017

Fix compatibility with Node.js master spdy-http2/node-spdy#312

Merged

lpinca mentioned this pull request May 11, 2017

Remove the upgradeReq property websockets/ws#1099

Closed

lpinca mentioned this pull request Jun 9, 2017

passing socket from master to worker causes a timeout issue where socket is null. #13435

Closed

lpinca mentioned this pull request Jun 9, 2017

http: handle cases where socket.server is null #13578

Closed

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

http: avoid retaining unneeded memory #11926

http: avoid retaining unneeded memory #11926

lpinca commented Mar 19, 2017

lpinca Mar 19, 2017 •

edited

Loading

bnoordhuis Mar 20, 2017

lpinca Mar 20, 2017 •

edited

Loading

bnoordhuis Mar 20, 2017

jasnell commented Mar 20, 2017

cjihrig left a comment

lpinca commented Mar 20, 2017

bnoordhuis Mar 20, 2017

lpinca commented Mar 20, 2017

bnoordhuis commented Mar 20, 2017

lpinca commented Mar 20, 2017

bnoordhuis Mar 20, 2017

jasnell commented Mar 22, 2017

jasnell commented Mar 22, 2017

lpinca commented Mar 22, 2017

jasnell commented Mar 22, 2017

MylesBorins commented Mar 28, 2017

MylesBorins commented Apr 10, 2017

ronkorving commented Apr 11, 2017

bnoordhuis commented Apr 11, 2017

lpinca commented Apr 11, 2017

lpinca commented Apr 11, 2017

http: avoid retaining unneeded memory #11926

http: avoid retaining unneeded memory #11926

Conversation

lpinca commented Mar 19, 2017

Checklist

Affected core subsystem(s)

lpinca Mar 19, 2017 • edited Loading

Choose a reason for hiding this comment

bnoordhuis Mar 20, 2017

Choose a reason for hiding this comment

lpinca Mar 20, 2017 • edited Loading

Choose a reason for hiding this comment

bnoordhuis Mar 20, 2017

Choose a reason for hiding this comment

jasnell commented Mar 20, 2017

cjihrig left a comment

Choose a reason for hiding this comment

lpinca commented Mar 20, 2017

bnoordhuis Mar 20, 2017

Choose a reason for hiding this comment

lpinca commented Mar 20, 2017

bnoordhuis commented Mar 20, 2017

lpinca commented Mar 20, 2017

bnoordhuis Mar 20, 2017

Choose a reason for hiding this comment

jasnell commented Mar 22, 2017

jasnell commented Mar 22, 2017

lpinca commented Mar 22, 2017

jasnell commented Mar 22, 2017

MylesBorins commented Mar 28, 2017

MylesBorins commented Apr 10, 2017

ronkorving commented Apr 11, 2017

bnoordhuis commented Apr 11, 2017

lpinca commented Apr 11, 2017

lpinca commented Apr 11, 2017

lpinca Mar 19, 2017 •

edited

Loading

lpinca Mar 20, 2017 •

edited

Loading