test: minor fixups for REPL eval tests #11946
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `process.on("exit")` event handlers are unnecessary, so it’s okay
to drop them.
Ref: nodejs#11871
addaleax
added
dont-land-on-v4.x
repl
cjihrig
approved these changes
Mar 20, 2017
evanlucas
approved these changes
Mar 20, 2017
jasnell
approved these changes
Mar 21, 2017
jasnell
pushed a commit
that referenced
this pull request
Mar 22, 2017
The `process.on("exit")` event handlers are unnecessary, so it’s okay
to drop them.
PR-URL: #11946
Ref: #11871
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
|
Landed in 64d0a73 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
process.on("exit")event handlers are unnecessary, so it’s okayto drop them.
Ref: #11871
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test,repl