test: increase querystring coverage #12163
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
targos
approved these changes
Apr 2, 2017
hiroppy
added
the
querystring
hiroppy
approved these changes
Apr 2, 2017
mscdex
reviewed
Apr 2, 2017
test/parallel/test-querystring.js
Outdated
| @@ -373,6 +373,8 @@ function demoDecode(str) { | |||
| } | |||
| check(qs.parse('a=a&b=b&c=c', null, null, { decodeURIComponent: demoDecode }), | |||
| { aa: 'aa', bb: 'bb', cc: 'cc' }); | |||
| check(qs.parse('a=a&b=b&c=c', null, '==', { decodeURIComponent: (str) => str }), | |||
| { 'a=a': '', 'b=b': '', 'c=c': '' }); | |||
There was a problem hiding this comment.
Indentation is a bit off here.
DavidCai1111
force-pushed
the
test/querystring-coverage
branch
from
7964455
to
635fcc8
Compare
|
@mscdex Done. Thanks for finding the nit, PTAL :) |
jasnell
approved these changes
Apr 3, 2017
cjihrig
approved these changes
Apr 3, 2017
jasnell
pushed a commit
that referenced
this pull request
Apr 4, 2017
PR-URL: #12163 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
|
Landed in dc7d9eb |
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Apr 10, 2017
PR-URL: nodejs#12163 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Apr 18, 2017
PR-URL: #12163 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Apr 19, 2017
PR-URL: #12163 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
andrew749
pushed a commit
to michielbaird/node
that referenced
this pull request
Jul 19, 2017
PR-URL: nodejs/node#12163 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test