Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix V8 test on big-endian machines #12186

Closed
wants to merge 1 commit into from
Closed

test: fix V8 test on big-endian machines #12186

wants to merge 1 commit into from

Conversation

addaleax
Copy link
Member

@addaleax addaleax commented Apr 3, 2017

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Apr 3, 2017
@addaleax
Copy link
Member Author

addaleax commented Apr 3, 2017

CI: https://ci.nodejs.org/job/node-test-commit/8852/

I’d like to land this if the it comes back green to un-break CI … sorry everyone :/

@addaleax addaleax added the v8 engine Issues and PRs related to the V8 dependency. label Apr 3, 2017
@gibfahn
Copy link
Member

gibfahn commented Apr 3, 2017

+1 to landing as soon as CI comes back (it already passed on linuxone so we're looking good).

Thanks for getting on this so quickly @addaleax !

@gibfahn gibfahn added aix Issues and PRs related to the AIX platform. ppc Issues and PRs related to the Power architecture. s390 Issues and PRs related to the s390 architecture. labels Apr 3, 2017
mhdawson
mhdawson approved these changes Apr 3, 2017
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

targos
targos approved these changes Apr 3, 2017
View reviewed changes
test/parallel/test-v8-serdes.js
assert.deepStrictEqual(v8.deserialize(buf),
new Uint16Array([0xdead, 0xbeef]));
expectedResult);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: this doesn't need to be on a new line anymore

@addaleax
Copy link
Member Author

addaleax commented Apr 3, 2017

CI is passing on aix, linuxone and ppc, so yes, this seems good. I’ve landed this in 9b05393 (with @targos’ style nit fixed) given that this change seems unlikely to result in surprises and all relevant platforms are covered.

Sorry again!

@addaleax addaleax closed this Apr 3, 2017
@addaleax addaleax deleted the v8-serdes-be-fix branch April 3, 2017 13:17
addaleax added a commit that referenced this pull request Apr 3, 2017
@addaleax
test: fix V8 test on big-endian machines
9b05393 
Ref: #12143 (comment)
PR-URL: #12186
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@jasnell jasnell mentioned this pull request Apr 4, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@targos targos targos approved these changes

@cjihrig cjihrig cjihrig approved these changes

@mhdawson mhdawson mhdawson approved these changes

@gibfahn gibfahn gibfahn approved these changes

Assignees
No one assigned
Labels
aix Issues and PRs related to the AIX platform. ppc Issues and PRs related to the Power architecture. s390 Issues and PRs related to the s390 architecture. test Issues and PRs related to the tests. v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@addaleax @gibfahn @targos @cjihrig @mhdawson @nodejs-github-bot