test: complete coverage for lib/assert.js #12239
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6481c93 modified `lib/assert.js` and added some tests for new functionality, but left a single line uncovered by tests. This adds a test that covers the currently-uncovered line (which is the final `return` statement in `setHasSimilarElement()`).`
Trott
added
assert
jasnell
approved these changes
Apr 6, 2017
cjihrig
approved these changes
Apr 6, 2017
lpinca
approved these changes
Apr 7, 2017
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Apr 7, 2017
6481c93 modified `lib/assert.js` and added some tests for new functionality, but left a single line uncovered by tests. This adds a test that covers the currently-uncovered line (which is the final `return` statement in `setHasSimilarElement()`).` PR-URL: nodejs#12239 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
|
Landed in 971fe67 |
|
cc @Trott |
|
This depends on semver-major #12142 so probably should not be backported. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
6481c93 modified
lib/assert.jsand added some tests for newfunctionality, but left a single line uncovered by tests. This adds a
test that covers the currently-uncovered line (which is the final
returnstatement insetHasSimilarElement()).`Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test assert