url: disallow invalid IPv4 in IPv6 parser

[watilde]

Fixes: #10655.

Checklist

• make -j4 test
• tests are included

Affected core subsystem(s)

url

[watilde]

ci: https://ci.nodejs.org/job/node-test-pull-request/7307/ (canceled)
ci: https://ci.nodejs.org/job/node-test-pull-request/7310/

[addaleax]

Maybe numbers_seen < 4 is a bit more intuitive than 4 > numbers_seen?

[watilde]

Sure thing. I've updated it :)

[bnoordhuis]

Why did you move this?

[watilde]

Oh, I was just reading the spec from the top to the bottom. The order comes from it, but yeah it's better to not touch for the performance. I will update it :)

[bnoordhuis]

This is covered by the if (numbers_seen > 0) { check at the start of the loop, isn't it?

[watilde]

I think it could happen if the numbers_seen is increased in the loop in the loop that the top loop can't detect: https://github.com/watilde/node/blob/521926ae2f502759c5fc752c82a2661a3dbf419e/src/node_url.cc#L179

[bnoordhuis]

I think I see what you mean but in that case it can be moved to right after the loop, right? And the ch == kEOL clause can be dropped because that's implied by while (ch != kEOL).

[watilde]

Oh you're right! I just got what you meant of right after the loop. I will update and let's wait for the spec update at whatwg/url#292. Thanks :)

[watilde]

The spec was updated at whatwg/url#292.

[watilde]

ci: https://ci.nodejs.org/job/node-test-pull-request/7393/

[watilde]

Landed in 1b99d8f. Thanks!