src: don't call uv_run() after 'exit' event #12344
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
|
Note: The test |
cjihrig
approved these changes
Apr 11, 2017
It makes timers and other libuv handles fire intermittently after the 'exit' event, contrary to what the documentation states. This change breaks parallel/test-async-wrap-throw-from-callback which I pragmatically resolved by removing the test. In all seriousness, it is scheduled for removal anyway in the upcoming async_wrap revamp so there isn't much point in sinking a lot of time in it.
bnoordhuis
force-pushed
the
fix-12322-break-9753
branch
from
4c05a79
to
2d4f4eb
Compare
bnoordhuis
changed the title
|
Fixed (what's in a name?) by removing the test. New CI: https://ci.nodejs.org/job/node-test-pull-request/7374/ |
bnoordhuis
added a commit
to bnoordhuis/io.js
that referenced
this pull request
Apr 19, 2017
It makes timers and other libuv handles fire intermittently after the 'exit' event, contrary to what the documentation states. Regression introduced in commit aac79df ("src: use stack-allocated Environment instances") from June last year that made the `while (handle_cleanup_waiting_ != 0) uv_run(event_loop(), UV_RUN_ONCE)` loop run unconditionally on exit because it merged CleanupHandles() into the Environment destructor. This change breaks parallel/test-async-wrap-throw-from-callback because the async_wrap idle handle is no longer cleaned up, which I resolved pragmatically by removing the test. In all seriousness, it is being removed in the upcoming async_wrap revamp - it doesn't make sense to sink a lot of time in it now. Fixes: nodejs#12322 PR-URL: nodejs#12344 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
2 tasks
danbev
pushed a commit
to danbev/node
that referenced
this pull request
May 2, 2017
It makes timers and other libuv handles fire intermittently after the 'exit' event, contrary to what the documentation states. Regression introduced in commit aac79df ("src: use stack-allocated Environment instances") from June last year that made the `while (handle_cleanup_waiting_ != 0) uv_run(event_loop(), UV_RUN_ONCE)` loop run unconditionally on exit because it merged CleanupHandles() into the Environment destructor. This change breaks parallel/test-async-wrap-throw-from-callback because the async_wrap idle handle is no longer cleaned up, which I resolved pragmatically by removing the test. In all seriousness, it is being removed in the upcoming async_wrap revamp - it doesn't make sense to sink a lot of time in it now. Fixes: nodejs#12322 PR-URL: nodejs#12344 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
3 tasks
|
@bnoordhuis looks like this was landed in 5ef6000 |
gibfahn
added
dont-land-on-v4.x
and removed
wip
|
I'm assuming/guessing this doesn't need to land on v6.x. Please raise a backport PR if that's not correct. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This breaks parallel/test-async-wrap-throw-from-callback.
Suggestions on how to keep the changes from #9753 working welcome.