Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: deprecate vm.runInDebugContext #12815

Closed
wants to merge 2 commits into from
Closed

src: deprecate vm.runInDebugContext #12815

wants to merge 2 commits into from

Conversation

joshgav
Copy link
Contributor

@joshgav joshgav commented May 3, 2017

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

Runtime deprecation of vm.runInDebugContext. To land in v9.x.

@joshgav joshgav added debugger vm Issues and PRs related to the vm subsystem. labels May 3, 2017
@nodejs-github-bot nodejs-github-bot added util Issues and PRs related to the built-in util module. vm Issues and PRs related to the vm subsystem. labels May 3, 2017
@joshgav joshgav mentioned this pull request May 3, 2017
Closed
4 tasks
@joshgav joshgav requested a review from ofrobots May 3, 2017 19:17
@Fishrock123
Copy link
Contributor

Will there be no similar behavior?

TimothyGu
TimothyGu suggested changes May 4, 2017
View reviewed changes
Copy link
Member

@TimothyGu TimothyGu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The deprecation status in doc/api/deprecations.md also needs to be changed to Runtime.

doc/api/vm.md
@@ -311,6 +311,11 @@ console.log(util.inspect(sandbox));
## vm.runInDebugContext(code)
<!-- YAML
added: v0.11.14
deprecated: v8.0.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change should go in separately with v8.x.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be REPLACEME rather than listing a specific version here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TimothyGu Done (but deprecated: v8.0.0 is correct since that’s when we docs-deprecated)

test/parallel/test-vm-debug-context.js Outdated
'a future version.';
common.expectWarning('DeprecationWarning', msg);
/* eslint-disable no-unused-vars */
const _ = vm.runInDebugContext();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why const _?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TimothyGu done

@addaleax
Copy link
Member

ping @joshgav

@targos targos mentioned this pull request May 30, 2017
Merged
@fhinkel
Copy link
Member

fhinkel commented Aug 3, 2017

@joshgav can we close this in favor of #13295? I'm trying to figure out the status of deprecating vm.runInDebugContext() but PRs are sending me in circles.

@TimothyGu
Copy link
Member

@fhinkel Yes I believe so.

@TimothyGu TimothyGu closed this Aug 31, 2017
@targos
Copy link
Member

targos commented Oct 21, 2017

Should we reopen since #13295 won't be in v9?

@addaleax
Copy link
Member

@targos yup

@addaleax addaleax reopened this Oct 22, 2017
@addaleax addaleax added this to the 9.0.0 milestone Oct 22, 2017
@addaleax addaleax force-pushed the deprecate-debugcontext-runtime branch from 1894455 to 66fa03d Compare October 22, 2017 14:39
@addaleax
Copy link
Member

addaleax commented Oct 22, 2017 •
edited
Loading

I don’t think @joshgav is very active right now, so I’ve rebased and force-pushed this.

@nodejs/tsc This needs to be in Node 9, ptal

CI: https://ci.nodejs.org/job/node-test-commit/13371/

(edit: self-assignment to keep track, shouldn’t stop anybody from merging)

@addaleax addaleax self-assigned this Oct 22, 2017
@targos targos added semver-major PRs that contain breaking changes and should be released in the next major version. and removed dont-land-on-v4.x labels Oct 23, 2017
@targos
Copy link
Member

targos commented Oct 23, 2017

I just pushed a commit to change the deprecation type in the documentation.

@addaleax
Copy link
Member

Landed in 88e55fe

@addaleax addaleax closed this Oct 23, 2017
addaleax pushed a commit that referenced this pull request Oct 23, 2017
@joshgav @addaleax
vm: deprecate vm.runInDebugContext
88e55fe 
PR-URL: #12815
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
addaleax pushed a commit to ayojs/ayo that referenced this pull request Oct 26, 2017
@joshgav @addaleax
vm: deprecate vm.runInDebugContext
4192ffa 
PR-URL: nodejs/node#12815
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@jasnell jasnell mentioned this pull request Oct 30, 2017
Merged
addaleax pushed a commit to ayojs/ayo that referenced this pull request Dec 7, 2017
@joshgav @addaleax
vm: deprecate vm.runInDebugContext
09d80f2 
PR-URL: nodejs/node#12815
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TimothyGu TimothyGu TimothyGu requested changes

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

@targos targos targos approved these changes

@ofrobots ofrobots Awaiting requested review from ofrobots

Assignees

@addaleax addaleax

Labels
semver-major PRs that contain breaking changes and should be released in the next major version. util Issues and PRs related to the built-in util module. vm Issues and PRs related to the vm subsystem.
Projects
None yet
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.
8 participants
@joshgav @Fishrock123 @addaleax @fhinkel @TimothyGu @targos @jasnell @nodejs-github-bot