net: check and throw on error for getsockname #12871

danbev · 2017-05-06T11:22:24Z

This commit attempts fix a TODO in net.js:
TODO(bnoordhuis) Check err and throw?

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
commit message follows commit guidelines

Affected core subsystem(s)

lib

danbev · 2017-05-06T11:23:29Z

CI: https://ci.nodejs.org/job/node-test-pull-request/7910/

refack · 2017-05-06T14:22:08Z

Does this have semver significance? It was a "safe" method, now it might throw?

refack · 2017-05-06T14:23:49Z

lib/net.js

-    // TODO(bnoordhuis) Check err and throw?
+    var err = this._handle.getsockname(out);
+    if (err) {
+      throw errnoException(err, 'address');


maybe

if (err) { self.emit('error', errnoException(err, 'address')); return; }

~~@addaleax won't throwing make this semver-major?~~
Ohh just saw you marked it.

Yeah, that’s why I’ve labelled it as a major. ;) But emitting an error event a) would be semver-major too and b) doesn’t really make sense here, it’s a fully synchronous call.

Ok. I agree.

refack

Anyway need to add a test for this.

danbev · 2017-05-06T15:09:48Z

CI: https://ci.nodejs.org/job/node-test-pull-request/7913/

addaleax

Looks good, but I am afraid you might need to tweak the error regexp in the test a bit more to work cross-platform ;)

danbev · 2017-05-06T15:16:27Z

Looks good, but I am afraid you might need to tweak the error regexp in the test a bit more to work cross-platform ;)

I guess I'll find out shortly about that 😄

refack · 2017-05-06T16:19:29Z

CI: https://ci.nodejs.org/job/node-test-commit/9697/

refack · 2017-05-06T17:52:32Z

@danbev Windows error is Error: address Unknown system error -1 so you need /^Error: address ([\w \-\d]+)$/
or do an if (common.isWindows) {

evanlucas

I'm not sure the benefits outweigh the cons on this one. I feel like this is a subtle change that could take down processes. I'm leaning towards -1 on this.

addaleax · 2017-05-06T18:47:47Z

@evanlucas Going through the errors that getsockname(2) can return according to my manpage copy:

EBADF The argument sockfd is not a valid file descriptor.
ENOTSOCK The file descriptor sockfd does not refer to a socket.

These would point to a bug in Node, I say throwing an error is okay.

EFAULT The addr argument points to memory not in a valid part of the process address space.
EINVAL addrlen is invalid (e.g., is negative).

These won’t happen/also would point to a serious bug in Node. Should definitely make some noise.

ENOBUFS Insufficient resources were available in the system to perform the operation.

Again, this probably never happens. Also, throwing seems better than returning invalid data here.

→ I think it’s safe to do this.

mscdex · 2017-05-06T19:37:05Z

The subsystem in the commit message should be net: instead of lib:

danbev · 2017-05-07T07:54:36Z

@danbev Windows error is Error: address Unknown system error -1 so you need /^Error: address ([\w -\d]+)$/
or do an if (common.isWindows) {

Thanks, updated now and I'll give CI another go.

This commit attempts fix a TODO in net.js: TODO(bnoordhuis) Check err and throw?

danbev · 2017-05-07T07:59:09Z

The subsystem in the commit message should be net: instead of lib:

Ah, let me fix that. thanks

danbev · 2017-05-07T08:05:17Z

Rebased CI: https://ci.nodejs.org/job/node-test-pull-request/7924/

danbev · 2017-05-08T06:12:13Z

@evanlucas Just wanted to ask if you are still leaning towards a -1 on this?

evanlucas · 2017-05-08T21:37:42Z

@addaleax thanks for the info. No objections from me :] Thanks!

@danbev nope

danbev · 2017-05-09T10:31:58Z

@evanlucas Great, thanks!

This commit attempts fix a TODO in net.js: TODO(bnoordhuis) Check err and throw? PR-URL: nodejs#12871 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

danbev · 2017-05-09T10:39:55Z

Landed in cf980b0

This commit attempts fix a TODO in net.js: TODO(bnoordhuis) Check err and throw? PR-URL: nodejs#12871 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

nodejs-github-bot added the net Issues and PRs related to the net subsystem. label May 6, 2017

refack reviewed May 6, 2017

View reviewed changes

refack suggested changes May 6, 2017

View reviewed changes

addaleax added the semver-major PRs that contain breaking changes and should be released in the next major version. label May 6, 2017

addaleax approved these changes May 6, 2017

View reviewed changes

santigimeno approved these changes May 6, 2017

View reviewed changes

refack approved these changes May 6, 2017

View reviewed changes

evanlucas reviewed May 6, 2017

View reviewed changes

danbev added 4 commits May 7, 2017 09:57

net: check and throw on error for getsockname

4141147

This commit attempts fix a TODO in net.js: TODO(bnoordhuis) Check err and throw?

add test

c321986

change regex to avoid plaform specific errors

ecb809c

update regex

1d1bd12

danbev changed the title ~~lib: check and throw on error for getsockname~~ net: check and throw on error for getsockname May 7, 2017

danbev force-pushed the handle-error-net.js branch from 4a17e17 to 1d1bd12 Compare May 7, 2017 08:03

jasnell approved these changes May 7, 2017

View reviewed changes

joyeecheung approved these changes May 7, 2017

View reviewed changes

cjihrig approved these changes May 8, 2017

View reviewed changes

danbev closed this May 9, 2017

danbev deleted the handle-error-net.js branch May 9, 2017 10:40

jasnell mentioned this pull request May 11, 2017

8.0.0 Release Proposal #12220

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

net: check and throw on error for getsockname #12871

net: check and throw on error for getsockname #12871

danbev commented May 6, 2017

danbev commented May 6, 2017

refack commented May 6, 2017

refack May 6, 2017

refack May 6, 2017 •

edited

Loading

addaleax May 6, 2017

refack May 6, 2017

refack left a comment

danbev commented May 6, 2017

addaleax left a comment

danbev commented May 6, 2017

refack commented May 6, 2017

refack commented May 6, 2017 •

edited

Loading

evanlucas left a comment

addaleax commented May 6, 2017

mscdex commented May 6, 2017

danbev commented May 7, 2017

danbev commented May 7, 2017

danbev commented May 7, 2017

danbev commented May 8, 2017

evanlucas commented May 8, 2017

danbev commented May 9, 2017

danbev commented May 9, 2017

net: check and throw on error for getsockname #12871

net: check and throw on error for getsockname #12871

Conversation

danbev commented May 6, 2017

Checklist

Affected core subsystem(s)

danbev commented May 6, 2017

refack commented May 6, 2017

refack May 6, 2017

Choose a reason for hiding this comment

refack May 6, 2017 • edited Loading

Choose a reason for hiding this comment

addaleax May 6, 2017

Choose a reason for hiding this comment

refack May 6, 2017

Choose a reason for hiding this comment

refack left a comment

Choose a reason for hiding this comment

danbev commented May 6, 2017

addaleax left a comment

Choose a reason for hiding this comment

danbev commented May 6, 2017

refack commented May 6, 2017

refack commented May 6, 2017 • edited Loading

evanlucas left a comment

Choose a reason for hiding this comment

addaleax commented May 6, 2017

mscdex commented May 6, 2017

danbev commented May 7, 2017

danbev commented May 7, 2017

danbev commented May 7, 2017

danbev commented May 8, 2017

evanlucas commented May 8, 2017

danbev commented May 9, 2017

danbev commented May 9, 2017

refack May 6, 2017 •

edited

Loading

refack commented May 6, 2017 •

edited

Loading