Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

benchmark: update an obsolete path #12904

Closed
wants to merge 1 commit into from
Closed

benchmark: update an obsolete path #12904

wants to merge 1 commit into from

Conversation

vsemozhetbyt
Copy link
Contributor

Checklist
Affected core subsystem(s)

benchmark, http

Refs: ff001c1
Refs: #12903

@vsemozhetbyt vsemozhetbyt added benchmark Issues and PRs related to the benchmark subsystem. http Issues or PRs related to the http subsystem. labels May 8, 2017
@nodejs-github-bot nodejs-github-bot added benchmark Issues and PRs related to the benchmark subsystem. http Issues or PRs related to the http subsystem. labels May 8, 2017
@vsemozhetbyt
Copy link
Contributor Author

Please, tell me if this can be landed without the common delay.

addaleax
addaleax approved these changes May 8, 2017
View reviewed changes
Copy link
Member

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, go ahead and land it if you want

@vsemozhetbyt
Copy link
Contributor Author

Landed in 65d6249

@vsemozhetbyt vsemozhetbyt deleted the fix-test-common-paths branch May 8, 2017 20:21
vsemozhetbyt added a commit that referenced this pull request May 8, 2017
@vsemozhetbyt
benchmark: update an obsolete path
65d6249 
PR-URL: #12904
Refs: #12903
Refs: ff001c1
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@vsemozhetbyt vsemozhetbyt mentioned this pull request May 8, 2017
Closed
anchnk pushed a commit to anchnk/node that referenced this pull request May 19, 2017
@vsemozhetbyt
benchmark: update an obsolete path
a0375c5 
PR-URL: nodejs#12904
Refs: nodejs#12903
Refs: nodejs@ff001c1
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@jasnell jasnell mentioned this pull request May 11, 2017
Closed
@gibfahn gibfahn mentioned this pull request Jun 15, 2017
Closed
3 tasks
gibfahn pushed a commit that referenced this pull request Jun 20, 2017
@vsemozhetbyt @gibfahn
benchmark: update an obsolete path
45ce269 
PR-URL: #12904
Refs: #12903
Refs: ff001c1
Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins pushed a commit that referenced this pull request Jul 11, 2017
@vsemozhetbyt @MylesBorins
benchmark: update an obsolete path
bb3f547 
PR-URL: #12904
Refs: #12903
Refs: ff001c1
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@MylesBorins MylesBorins mentioned this pull request Jul 18, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax addaleax approved these changes

Assignees
No one assigned
Labels
benchmark Issues and PRs related to the benchmark subsystem. http Issues or PRs related to the http subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vsemozhetbyt @addaleax @gibfahn @nodejs-github-bot