Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

https: support agent construction without new #12927

Merged
merged 1 commit into from
May 11, 2017
+10 −0
Merged

https: support agent construction without new #12927

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions lib/https.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,9 @@ function createConnection(port, host, options) {


function Agent(options) {
if (!(this instanceof Agent))
return new Agent(options);

http.Agent.call(this, options);
this.defaultPort = 443;
this.protocol = 'https:';
Expand Down
7 changes: 7 additions & 0 deletions test/parallel/test-https-agent-constructor.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
'use strict';
require('../common');
const assert = require('assert');
const https = require('https');

assert.doesNotThrow(() => { https.Agent(); });
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it make sense to add an assertion like this?

assert.ok(https.Agent() instanceof Agent);

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assertion added

assert.ok(https.Agent() instanceof https.Agent);