test: track callback invocations #13010
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use `common.mustCall()` and `common.mustNotCall()` to check that callbacks are invoked the expected number of times in test-net-listen-shared-ports.
mscdex
added
net
lpinca
approved these changes
May 13, 2017
cjihrig
approved these changes
May 14, 2017
gibfahn
approved these changes
May 14, 2017
refack
approved these changes
May 14, 2017
jasnell
approved these changes
May 15, 2017
|
Rerun linux (previous run had tap parse issue): https://ci.nodejs.org/job/node-test-commit-linux/9943/ |
addaleax
approved these changes
May 18, 2017
|
Landed in 7e5ed8b |
addaleax
pushed a commit
that referenced
this pull request
May 18, 2017
Use `common.mustCall()` and `common.mustNotCall()` to check that callbacks are invoked the expected number of times in test-net-listen-shared-ports. PR-URL: #13010 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
2 tasks
|
Cross reference #13100 |
anchnk
pushed a commit
to anchnk/node
that referenced
this pull request
May 19, 2017
Use `common.mustCall()` and `common.mustNotCall()` to check that callbacks are invoked the expected number of times in test-net-listen-shared-ports. PR-URL: nodejs#13010 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
3 tasks
MylesBorins
pushed a commit
that referenced
this pull request
Jul 17, 2017
Use `common.mustCall()` and `common.mustNotCall()` to check that callbacks are invoked the expected number of times in test-net-listen-shared-ports. PR-URL: #13010 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
common.mustCall()andcommon.mustNotCall()to check thatcallbacks are invoked the expected number of times in
test-net-listen-shared-ports.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test net