build: don't print directory for GNUMake #13042
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently when running make targets the directory is printed on some operating systems (Linux for example): $ make lint make[1]: Entering directory '/work/node' Running JS linter... ./node tools/eslint/bin/eslint.js --cache --rulesdir=tools/eslint-rules --ext=.js,.md \ benchmark doc lib test tools make[1]: Leaving directory '/work/node' make[1]: Entering directory '/work/node' Running C++ linter... On other operating systems the directory is not printed. This commit suggests adding a flag to make this consistent for GNUMake by not printing the directory.
nodejs-github-bot
added
the
build
gibfahn
approved these changes
May 16, 2017
|
The only make directory output on the Linux job is now what comes from |
danbev
added a commit
to danbev/node
that referenced
this pull request
May 17, 2017
Currently when running make targets the directory is printed on some operating systems (Linux for example): $ make lint make[1]: Entering directory '/work/node' Running JS linter... ./node tools/eslint/bin/eslint.js --cache --rulesdir=tools/eslint-rules --ext=.js,.md \ benchmark doc lib test tools make[1]: Leaving directory '/work/node' make[1]: Entering directory '/work/node' Running C++ linter... On other operating systems the directory is not printed. This commit suggests adding a flag to make this consistent for GNUMake by not printing the directory. PR-URL: nodejs#13042 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
|
Landed in ad7b98b |
anchnk
pushed a commit
to anchnk/node
that referenced
this pull request
May 19, 2017
Currently when running make targets the directory is printed on some operating systems (Linux for example): $ make lint make[1]: Entering directory '/work/node' Running JS linter... ./node tools/eslint/bin/eslint.js --cache --rulesdir=tools/eslint-rules --ext=.js,.md \ benchmark doc lib test tools make[1]: Leaving directory '/work/node' make[1]: Entering directory '/work/node' Running C++ linter... On other operating systems the directory is not printed. This commit suggests adding a flag to make this consistent for GNUMake by not printing the directory. PR-URL: nodejs#13042 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when running make targets the directory is printed on some
operating systems (Linux for example):
On other operating systems the directory is not printed. This commit
suggests adding a flag to make this consistent for GNUMake by not
printing the directory.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
build