Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: redirect-warnings to file, not path #13120

Closed
wants to merge 1 commit into from
Closed

src: redirect-warnings to file, not path #13120

wants to merge 1 commit into from

Conversation

sam-github
Copy link
Contributor

Use file as name of the argument, as the CLI documentation does.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

src,doc?

@sam-github
src: redirect-warnings to file, not path
a645683 
Use `file` as name of the argument, as the CLI documentation does.
@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label May 19, 2017
@sam-github
Copy link
Contributor Author

cf. https://github.com/nodejs/node/blob/master/doc/api/cli.md#--redirect-warningsfile

@sam-github
Copy link
Contributor Author

ci: https://ci.nodejs.org/job/node-test-pull-request/8191/

@mscdex mscdex added the cli Issues and PRs related to the Node.js command line interface. label May 19, 2017
refack
refack approved these changes May 19, 2017
View reviewed changes
Copy link
Contributor

@refack refack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes more sense

@addaleax
Copy link
Member

Landed in a886b17

@addaleax addaleax closed this May 23, 2017
addaleax pushed a commit that referenced this pull request May 23, 2017
@sam-github @addaleax
src: redirect-warnings to file, not path
a886b17 
Use `file` as name of the argument, as the CLI documentation does.

PR-URL: #13120
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@sam-github sam-github deleted the clarify-redirect-warnings-usage branch May 23, 2017 19:50
jasnell pushed a commit that referenced this pull request May 24, 2017
@sam-github @jasnell
src: redirect-warnings to file, not path
1ad17f2 
Use `file` as name of the argument, as the CLI documentation does.

PR-URL: #13120
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
jasnell pushed a commit that referenced this pull request May 28, 2017
@sam-github @jasnell
src: redirect-warnings to file, not path
4cbdac3 
Use `file` as name of the argument, as the CLI documentation does.

PR-URL: #13120
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@jasnell jasnell mentioned this pull request May 28, 2017
Closed
@gibfahn gibfahn mentioned this pull request Jun 15, 2017
Closed
3 tasks
@MylesBorins
Copy link
Contributor

This does not land cleanly in LTS. Please feel free to manually backport. Please also feel free to replace do-not-land if it is being backported

@sam-github
Copy link
Contributor Author

Depends on #10116 which has not yet been backported to 6.x. I'll look into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@refack refack refack approved these changes

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

@gibfahn gibfahn gibfahn approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. cli Issues and PRs related to the Node.js command line interface.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@sam-github @addaleax @MylesBorins @refack @jasnell @lpinca @cjihrig @gibfahn @mscdex @nodejs-github-bot