Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: update code example for Windows in stream.md #13138

Closed
wants to merge 1 commit into from
Closed

doc: update code example for Windows in stream.md #13138

wants to merge 1 commit into from

Conversation

vsemozhetbyt
Copy link
Contributor

Checklist
Affected core subsystem(s)

doc, stream

Commands with single quotes fail in cmd.exe shell (while being OK in Git Bash for Windows):

> curl localhost:1337 -d '{}'
error: Unexpected token ' in JSON at position 0
> curl localhost:1337 -d '"foo"'
error: Unexpected token ' in JSON at position 0
> curl localhost:1337 -d 'not json'
error: Unexpected token ' in JSON at position 0curl: (6) Couldn't resolve host 'json''

Commands with double quotes are OK in both cmd.exe shell and Git Bash for Windows.

@vsemozhetbyt vsemozhetbyt added doc Issues and PRs related to the documentations. stream Issues and PRs related to the stream subsystem. windows Issues and PRs related to the Windows platform. labels May 21, 2017
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. stream Issues and PRs related to the stream subsystem. labels May 21, 2017
mcollina
mcollina approved these changes May 22, 2017
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vsemozhetbyt
Copy link
Contributor Author

Landed in 9278ce2

@vsemozhetbyt vsemozhetbyt deleted the stream-curl-win branch May 24, 2017 00:51
vsemozhetbyt added a commit that referenced this pull request May 24, 2017
@vsemozhetbyt
doc: update code example for Windows in stream.md
9278ce2 
PR-URL: #13138
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
jasnell pushed a commit that referenced this pull request May 24, 2017
@vsemozhetbyt @jasnell
doc: update code example for Windows in stream.md
82c361e 
PR-URL: #13138
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
jasnell pushed a commit that referenced this pull request May 28, 2017
@vsemozhetbyt @jasnell
doc: update code example for Windows in stream.md
2c45e6f 
PR-URL: #13138
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell jasnell mentioned this pull request May 28, 2017
Closed
@gibfahn gibfahn mentioned this pull request Jun 15, 2017
Closed
3 tasks
MylesBorins pushed a commit that referenced this pull request Jul 17, 2017
@vsemozhetbyt @MylesBorins
doc: update code example for Windows in stream.md
cb03bd1 
PR-URL: #13138
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Jul 18, 2017
Merged
@leonardoadame leonardoadame mentioned this pull request Nov 30, 2023
Open
@aliscco aliscco mentioned this pull request Dec 1, 2023
Open
This was referenced Dec 1, 2023
Open
Open
Open
Open
@aliscco aliscco mentioned this pull request Dec 2, 2023
Open
@leonardoadame leonardoadame mentioned this pull request Dec 3, 2023
Open
This was referenced May 14, 2024
Open
Open
@aliscco aliscco mentioned this pull request May 15, 2024
Open
This was referenced May 16, 2024
Open
Open
@aliscco aliscco mentioned this pull request May 17, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

@gibfahn gibfahn gibfahn approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. stream Issues and PRs related to the stream subsystem. windows Issues and PRs related to the Windows platform.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@vsemozhetbyt @mcollina @jasnell @addaleax @lpinca @cjihrig @gibfahn @MylesBorins @nodejs-github-bot