src: allow --tls-cipher-list in NODE_OPTIONS #13172

sam-github · 2017-05-23T16:14:31Z

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
documentation is changed or added
commit message follows commit guidelines

Affected core subsystem(s)

src, tls

refack · 2017-05-23T16:24:46Z

Did you forget https://github.com/nodejs/node/blob/master/doc/api/cli.md#node_optionsoptions? Or it should stay undocumented.

sam-github · 2017-05-23T16:35:20Z

@refack My update and your noticing the miss passed on the wire :-)

mhdawson

LGTM

refack

😄

sam-github · 2017-05-25T15:35:17Z

ci: https://ci.nodejs.org/job/node-test-pull-request/8301/

sam-github · 2017-05-25T15:39:35Z

@nodejs/build FIPS failure is unrelated, but reproduceable and genuine, from https://ci.nodejs.org/job/node-test-commit-linux-fips/8660/nodes=ubuntu1404-64/console:

+ curl -LO https://openssl.org/source/openssl-fips-2.0.9.tar.gz
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
  0     0    0     0    0     0      0      0 --:--:--  0:00:01 --:--:--     0
  0     0    0     0    0     0      0      0 --:--:--  0:00:02 --:--:--     0
100   342  100   342    0     0    126      0  0:00:02  0:00:02 --:--:--   126

100  4239  100  4239    0     0   1218      0  0:00:03  0:00:03 --:--:--  1218
+ gunzip openssl-fips-2.0.9.tar.gz

gzip: openssl-fips-2.0.9.tar.gz: not in gzip format

I did this locally, the file isn't tgz, it is

<!DOCTYPE html>
<html lang="en">
<!-- head.inc -->
  <title>
  /err404.html
  </title>
  <meta charset="utf-8">
  <meta name="author" content="OpenSSL Foundation, Inc.">
...

What's up?

gibfahn · 2017-05-25T15:44:39Z

Looks like the URL has changed from:

https://www.openssl.org/source/openssl-fips-2.0.9.tar.gz to
https://www.openssl.org/source/old/fips/openssl-fips-2.0.9.tar.gz

Not sure that is the correct new link, maybe @mhdawson can confirm?

sam-github · 2017-05-25T15:44:59Z

It seems not coincidental that this happened about when OpenSSL released:

https://www.openssl.org/source/ shows a new FIPS 2.0.13, and 2.0.9 has been shuffled to a new location. This is annoying, perhaps we can bring the lack of stable URLs up with OpenSSL? New location:

% curl -LO https://openssl.org/source/old/fips/openssl-fips-2.0.9.tar.gz
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   351  100   351    0     0    323      0  0:00:01  0:00:01 --:--:--   323
100 1391k  100 1391k    0     0   388k      0  0:00:03  0:00:03 --:--:-- 1022k
core/tls-node (env-ciphersuites $ u=) % file openssl-fips-2.0.9.tar.gz
openssl-fips-2.0.9.tar.gz: gzip compressed data, last modified: Sat Oct 25 12:37:15 2014, max compression, from Unix

PR-URL: nodejs#13172 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>

PR-URL: #13172 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>

sam-github · 2017-05-30T21:44:11Z

See #12677

MylesBorins · 2017-07-17T16:42:26Z

Should this not have been semver minor?

sam-github · 2017-07-17T17:06:37Z

yes, semver minor

PR-URL: nodejs#13172 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>

Backport-PR-URL: #12677 PR-URL: #13172 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>

Notable Changes: * assert: - assert.fail() can now take one or two arguments (Rich Trott) #12293 * crypto: - add sign/verify support for RSASSA-PSS (Tobias Nießen) #11705 * deps: - upgrade openssl sources to 1.0.2m (Shigeki Ohtsu) #16691 - upgrade libuv to 1.15.0 (cjihrig) #15745 - upgrade libuv to 1.14.1 (cjihrig) #14866 - upgrade libuv to 1.13.1 (cjihrig) #14117 - upgrade libuv to 1.12.0 (cjihrig) #13306 * fs: - Add support for fs.write/fs.writeSync(fd, buffer, cb) and fs.write/fs.writeSync(fd, buffer, offset, cb) as documented (Andreas Lind) #7856 * inspector: - enable --inspect-brk (Refael Ackermann) #12615 * process: - add --redirect-warnings command line argument (James M Snell) #10116 * src: - allow CLI args in env with NODE_OPTIONS (Sam Roberts) #12028) - --abort-on-uncaught-exception in NODE_OPTIONS (Sam Roberts) #13932 - allow --tls-cipher-list in NODE_OPTIONS (Sam Roberts) #13172 - use SafeGetenv() for NODE_REDIRECT_WARNINGS (Sam Roberts) #12677 * test: - remove common.fail() (Rich Trott) #12293 PR-URL: #16263

nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label May 23, 2017

sam-github added the tls Issues and PRs related to the tls subsystem. label May 23, 2017

cjihrig approved these changes May 23, 2017

View reviewed changes

sam-github force-pushed the env-ciphersuites branch from 5347fc1 to 4260b96 Compare May 23, 2017 16:26

mscdex added the cli Issues and PRs related to the Node.js command line interface. label May 23, 2017

mhdawson approved these changes May 23, 2017

View reviewed changes

refack approved these changes May 24, 2017

View reviewed changes

jasnell approved these changes May 24, 2017

View reviewed changes

gibfahn approved these changes May 24, 2017

View reviewed changes

sam-github force-pushed the env-ciphersuites branch from 4260b96 to 41473ce Compare May 25, 2017 15:30

This was referenced May 25, 2017

openssl fips .tar.gz has moved, or been replaced #13219

Closed

is it possible to have permanent URLs for tarball downloads? openssl/openssl#3556

Closed

sam-github force-pushed the env-ciphersuites branch from 41473ce to b659385 Compare May 25, 2017 16:19

sam-github merged commit b659385 into nodejs:master May 25, 2017

sam-github deleted the env-ciphersuites branch May 26, 2017 03:28

jasnell mentioned this pull request May 28, 2017

8.0.0 Release Proposal #12220

Closed

sam-github mentioned this pull request May 30, 2017

(v6.x backport) src: allow CLI args in env with NODE_OPTIONS #12677

Closed

4 tasks

gibfahn mentioned this pull request Jun 15, 2017

Auditing for 6.11.1 nodejs/Release#230

Closed

3 tasks

MylesBorins added the backported-to-v6.x label Jul 17, 2017

sam-github added the semver-minor PRs that contain new features and should be released in the next minor version. label Jul 17, 2017

MylesBorins mentioned this pull request Oct 17, 2017

v6.12.0 proposal #16263

Merged

MylesBorins mentioned this pull request Nov 3, 2017

v4.8.6 proposal #16500

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

src: allow --tls-cipher-list in NODE_OPTIONS #13172

src: allow --tls-cipher-list in NODE_OPTIONS #13172

sam-github commented May 23, 2017 •

edited

Loading

refack commented May 23, 2017

sam-github commented May 23, 2017

mhdawson left a comment

refack left a comment

sam-github commented May 25, 2017

sam-github commented May 25, 2017

gibfahn commented May 25, 2017

sam-github commented May 25, 2017

sam-github commented May 30, 2017

MylesBorins commented Jul 17, 2017

sam-github commented Jul 17, 2017

src: allow --tls-cipher-list in NODE_OPTIONS #13172

src: allow --tls-cipher-list in NODE_OPTIONS #13172

Conversation

sam-github commented May 23, 2017 • edited Loading

Checklist

Affected core subsystem(s)

refack commented May 23, 2017

sam-github commented May 23, 2017

mhdawson left a comment

Choose a reason for hiding this comment

refack left a comment

Choose a reason for hiding this comment

sam-github commented May 25, 2017

sam-github commented May 25, 2017

gibfahn commented May 25, 2017

sam-github commented May 25, 2017

sam-github commented May 30, 2017

MylesBorins commented Jul 17, 2017

sam-github commented Jul 17, 2017

sam-github commented May 23, 2017 •

edited

Loading