Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

path: fix posix.relative returns different results #13738

Closed
wants to merge 5 commits into from
Closed

path: fix posix.relative returns different results #13738

wants to merge 5 commits into from

Commits on Jun 22, 2017

  1. path: fix posix.relative returns different results 

    Throw an error `ERR_UNSUPPORTED_PLATFOMR` when direct use
`path.posix.resolve` on Windows or direct use `path.win32.resolve`
on *nix.

Update docs, list win32 functions do not support direct use on
*nix and posix functions do not support direct use on Windows.

Update tests, only run current platform type test.

Fixes: nodejs#13683
Refs: nodejs#13714
    @DuanPengfei
    DuanPengfei committed Jun 22, 2017
    Configuration menu
    Copy the full SHA
    466faeb View commit details
    Browse the repository at this point in the history

  2. fix: typo

    @DuanPengfei
    DuanPengfei committed Jun 22, 2017
    Configuration menu
    Copy the full SHA
    0864e8e View commit details
    Browse the repository at this point in the history

  3. fix: rm unnecessary test

    @DuanPengfei
    DuanPengfei committed Jun 22, 2017
    Configuration menu
    Copy the full SHA
    acfdb47 View commit details
    Browse the repository at this point in the history

  4. feat: resolve only throw error when rely on cwd

    @DuanPengfei
    DuanPengfei committed Jun 22, 2017
    Configuration menu
    Copy the full SHA
    8d604e1 View commit details
    Browse the repository at this point in the history

  5. doc: update path.posix and path.win32 doc

    @DuanPengfei
    DuanPengfei committed Jun 22, 2017
    Configuration menu
    Copy the full SHA
    c8bbf22 View commit details
    Browse the repository at this point in the history