-
Notifications
You must be signed in to change notification settings - Fork 29.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
repl: remove NODE_REPL_HISTORY_FILE #13876
Conversation
Maybe we should create an official end of life deprecation entry before removing. @jasnell WDYT? |
Yep, I agree. Let's mark it end of life in |
@cjihrig @jasnell is this really necessary in this case? The old format would immediately be migrated to the new format by starting the repl. So it's a one time process for each user that specifically used io.js 2 and it was already deprecated in io.js 3. It is a history file so would anyone want to rely on a history file that would be two years old? |
Since it's a low-risk/low-reward situation, I believe going by the book is just safer... So we'll need to mark it EOL in the docs. |
Agree. Let's mark it EOL in 9.x |
Refs: nodejs#13876 Just a note that I've been trying to add tests for this, but it's been difficult because it seems like most REPL tests directly patch into internals, and are not run via a child process.
0b28590
to
11dd505
Compare
I rebased this and even though the run-time deprecation did not yet land, I personally feel like it is absolutely fine to directly go to the end-of-life as this does not hurt anyone even in the very unlikely case that someone still uses io.js 2.x and directly updates to 10.x. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Landed in 60c9ad7. |
PR-URL: nodejs#13876 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
PR-URL: nodejs#13876 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This is a alternative to #13733
The history file was only active in io.js 2.x and was deprecated in io.js 3.0. I think it's safe to remove this instead of fixing the error handling but I thought having both here to decide on is the best to do.
I'll finish the tests if it's decided that it should be removed instead of fixed.
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passesAffected core subsystem(s)
repl