benchmark: use much smaller values for n in some http tests #14002
Conversation
nodejs-github-bot
added
benchmark
|
No comment on the changes themselves, but the commit subsystem should be |
|
Ping @nodejs/benchmarking @mscdex |
psmarshall
changed the title
|
@cjihrig Thanks, I've updated the subsystem. |
There was a problem hiding this comment.
I just checked the benchmarks and with these low numbers the benchmark is not fully limited by the CPU and the numbers change to what they would be with higher n.
It will depend on the CPU but I would not recommend to go much below 5e7. I normally always change n when I run benchmarks locally depending on if I want to have a high accuracy or a glimpse at the likely outcome.
|
Ping @psmarshall would you mind updating the numbers once more? |
|
I decided to land this as is even with my comment. We can always increase the numbers when running the benchmarks locally if needed. Landed in 8a968e4 |
PR-URL: #14002 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #14002 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: nodejs/node#14002 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: nodejs/node#14002 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #14002 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #14002 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
benchmark
The n values here are really, really high right now, and we can still get high confidence (3 stars) with this much lower n value. This makes the benchmarks run a lot faster without sacrificing accuracy.