Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: refactor test-vm-new-script-new-context #14536

Closed
wants to merge 1 commit into from
Closed

test: refactor test-vm-new-script-new-context #14536

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Jul 29, 2017

  • block scope test cases
  • clean up global leaks in individual test cases
  • enable global variable leak checking
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test vm

@Trott Trott added test Issues and PRs related to the tests. vm Issues and PRs related to the vm subsystem. labels Jul 29, 2017
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Jul 29, 2017
@refack
Copy link
Contributor

refack commented Jul 29, 2017

Why not remove all the console.log()s as well.

@Trott
Copy link
Member Author

Trott commented Jul 29, 2017

Why not remove all the console.log()s as well.

@refack Basically for the reasons stated at #14458 (comment).

That said, if there's consensus that they ought to go (or even if you just feel strongly about it), then I'm fine getting rid of them.

cjihrig
cjihrig approved these changes Jul 31, 2017
View reviewed changes
Copy link
Contributor

@cjihrig cjihrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'd also prefer the console calls be removed.

@refack
Copy link
Contributor

refack commented Jul 31, 2017

Why not remove all the console.log()s as well.

refack Basically for the reasons stated at #14458 (comment).

If they are insightful no rush removing them (although I am pro the common.log() concept)

@Trott
test: refactor test-vm-new-script-new-context
1766db0 
* block scope test cases
* clean up global leaks in individual test cases
* enable global variable leak checking
* remove console.error() statements
@Trott
Copy link
Member Author

Trott commented Aug 1, 2017

ATTN haters of console.error() in tests! They have now been removed from this one.

CI: https://ci.nodejs.org/job/node-test-pull-request/9425/

jasnell
jasnell approved these changes Aug 1, 2017
View reviewed changes
Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (if only because those console.error statements are gone! ;-) ...)

@Trott
Copy link
Member Author

Trott commented Aug 1, 2017

Landed in ff1a519

@Trott Trott closed this Aug 1, 2017
Trott added a commit that referenced this pull request Aug 1, 2017
@Trott
test: refactor test-vm-new-script-new-context
ff1a519 
* block scope test cases
* clean up global leaks in individual test cases
* enable global variable leak checking
* remove console.error() statements

PR-URL: #14536
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax pushed a commit that referenced this pull request Aug 1, 2017
@Trott @addaleax
test: refactor test-vm-new-script-new-context
9f50db2 
* block scope test cases
* clean up global leaks in individual test cases
* enable global variable leak checking
* remove console.error() statements

PR-URL: #14536
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@addaleax addaleax mentioned this pull request Aug 2, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Aug 16, 2017
@Trott @MylesBorins
test: refactor test-vm-new-script-new-context
fdc61ce 
* block scope test cases
* clean up global leaks in individual test cases
* enable global variable leak checking
* remove console.error() statements

PR-URL: #14536
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Aug 16, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Aug 16, 2017
@Trott @MylesBorins
test: refactor test-vm-new-script-new-context
435ab00 
* block scope test cases
* clean up global leaks in individual test cases
* enable global variable leak checking
* remove console.error() statements

PR-URL: #14536
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Sep 3, 2017
@Trott @MylesBorins
test: refactor test-vm-new-script-new-context
c1c3a5a 
* block scope test cases
* clean up global leaks in individual test cases
* enable global variable leak checking
* remove console.error() statements

PR-URL: #14536
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Sep 5, 2017
@Trott @MylesBorins
test: refactor test-vm-new-script-new-context
4b9de44 
* block scope test cases
* clean up global leaks in individual test cases
* enable global variable leak checking
* remove console.error() statements

PR-URL: #14536
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced Sep 5, 2017
Closed
Closed
Closed
Closed
Closed
@Trott Trott deleted the refactor-vm-test branch January 13, 2022 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@refack refack refack approved these changes

@jasnell jasnell jasnell approved these changes

@cjihrig cjihrig cjihrig approved these changes

Assignees
No one assigned
Labels
test Issues and PRs related to the tests. vm Issues and PRs related to the vm subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Trott @refack @jasnell @cjihrig @MylesBorins @nodejs-github-bot