Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: return MaybeLocal in AsyncWrap::MakeCallback #14549

Closed
wants to merge 1 commit into from
Closed

src: return MaybeLocal in AsyncWrap::MakeCallback #14549

wants to merge 1 commit into from

Conversation

tniessen
Copy link
Member

@tniessen tniessen commented Jul 31, 2017 •
edited
Loading

MakeCallback can return empty Locals, so it is a good idea to use MaybeLocals here as @trevnorris suggested.

I might have missed some uses where the return value is not used, but the code compiles and tests pass, plus these changes should not change the behavior of MakeCallback anyway.

Partial CI: https://ci.nodejs.org/job/node-test-commit-linuxone/7638/
Linter CI: https://ci.nodejs.org/job/node-test-linter/10833/

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

src

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. labels Jul 31, 2017
@tniessen tniessen self-assigned this Jul 31, 2017
TimothyGu
TimothyGu approved these changes Jul 31, 2017
View reviewed changes
Copy link
Member

@TimothyGu TimothyGu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

async-wrap.* LGTM. Other parts rubber-stamp LGTM.

bnoordhuis
bnoordhuis approved these changes Jul 31, 2017
View reviewed changes
Copy link
Member

@bnoordhuis bnoordhuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It would be nice as a follow-up to replace all the non-context calls to Int32Value(), IntegerValue(), etc. with their context overloads.

@tniessen
Copy link
Member Author

tniessen commented Aug 2, 2017

Landed in 98bae29.

CI on master: https://ci.nodejs.org/job/node-test-commit-linuxone/7700/

@tniessen tniessen closed this Aug 2, 2017
tniessen added a commit that referenced this pull request Aug 2, 2017
@tniessen
src: return MaybeLocal in AsyncWrap::MakeCallback
98bae29 
PR-URL: #14549
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
addaleax pushed a commit that referenced this pull request Aug 2, 2017
@tniessen @addaleax
src: return MaybeLocal in AsyncWrap::MakeCallback
fa3aa2e 
PR-URL: #14549
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@addaleax addaleax mentioned this pull request Aug 2, 2017
Merged
@MylesBorins MylesBorins added baking-for-lts PRs that need to wait before landing in a LTS release. lts-watch-v6.x labels Aug 16, 2017
@MylesBorins MylesBorins removed the baking-for-lts PRs that need to wait before landing in a LTS release. label Aug 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnoordhuis bnoordhuis bnoordhuis approved these changes

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

@TimothyGu TimothyGu TimothyGu approved these changes

@cjihrig cjihrig cjihrig approved these changes

@trevnorris trevnorris Awaiting requested review from trevnorris

Assignees

@tniessen tniessen

Labels
c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@tniessen @bnoordhuis @jasnell @addaleax @TimothyGu @cjihrig @MylesBorins @nodejs-github-bot