[v6.x backport] tools: eslint - use error and off
#14841
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
build
refack
force-pushed
the
backport-14061-to-v6.x
branch
from
ac9f02d
to
c778371
Compare
MylesBorins
force-pushed
the
v6.x-staging
branch
from
cebce8b
to
5a93c16
Compare
|
@refack this is going to need a rebase, there are some conflicts |
2 tasks
MylesBorins
force-pushed
the
v6.x-staging
branch
2 times, most recently
from
f9419c2
to
403c465
Compare
benjamingr
reviewed
Sep 1, 2017
README.md
Outdated
| * [iarna](https://github.com/iarna) - | ||
| **Rebecca Turner** <me@re-becca.org> | ||
| * [imran-iq](https://github.com/imran-iq) - | ||
| **Imran Iqbal** <imran@imraniqbal.org> | ||
| * [imyller](https://github.com/imyller) - | ||
| **Ilkka Myller** <ilkka.myller@nodefield.com> | ||
| * [indutny](https://github.com/indutny) - |
There was a problem hiding this comment.
Not sure why these changes are here?
MylesBorins
force-pushed
the
v6.x-staging
branch
2 times, most recently
from
aaf4e13
to
31f572c
Compare
|
@refack, rebase needed |
refack
force-pushed
the
backport-14061-to-v6.x
branch
from
c778371
to
233c91e
Compare
|
@MylesBorins Rebased |
|
oh geeze oh man... needs one more rebase (I guess I landed something in the last hour. Sorry |
PR-URL: nodejs#14061 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> # Conflicts: # .eslintrc.yaml # benchmark/.eslintrc.yaml # doc/.eslintrc.yaml # test/.eslintrc.yaml # tools/.eslintrc.yaml
refack
force-pushed
the
backport-14061-to-v6.x
branch
from
233c91e
to
328f04c
Compare
NP, the engine was still warm 😄 |
MylesBorins
pushed a commit
that referenced
this pull request
Sep 19, 2017
Backport-PR-URL: #14841 PR-URL: #14061 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
|
landed in f7b6d19 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR-URL: #14061
Reviewed-By: Benjamin Gruenbaum benjamingr@gmail.com
Reviewed-By: Michaël Zasso targos@protonmail.com
Reviewed-By: Vse Mozhet Byt vsemozhetbyt@gmail.com
Reviewed-By: Colin Ihrig cjihrig@gmail.com
Reviewed-By: Franziska Hinkelmann franziska.hinkelmann@gmail.com
Reviewed-By: Luigi Pinca luigipinca@gmail.com
Conflicts:
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
tools