lib: deprecate the smalloc module #1564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upcoming V8 changes will make it impossible to keep supporting the smalloc module so deprecate it now and tell people to switch to typed arrays. The module is used in core in a few places so this commit makes the public module private and replaces the public part with wrappers that print deprecation notices. PR-URL: nodejs#1564 Reviewed-By: Domenic Denicola <domenic@domenicdenicola.com> Reviewed-By: Trevor Norris <trev.norris@gmail.com>
| return false; | ||
|
|
||
| return smalloc.hasExternalData(obj); | ||
| } |
There was a problem hiding this comment.
lib/smalloc.js was moved to lib/internal/smalloc.js, then a stub lib/smalloc.js. Unfortunately, git/github doesn't quite fathom that and the diff is noisier because of it.
|
LGTM but would prefer @trevnorris's sign-off. |
|
@bnoordhuis Have we deprecated Changes as they are LGTM. |
bnoordhuis
force-pushed
the
deprecate-smalloc-module
branch
from
0f929ca
to
d5ce47e
Compare
I think this is a first. I'll open another PR for that. |
|
Fare thee well |
brendanashworth
added
smalloc
semver-minor
|
Are doc changes being committed in separately? |
|
Wups, I forgot to commit that. I'll open a new pull request for that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upcoming V8 changes will make it impossible to keep supporting the
smalloc module so deprecate it now and tell people to switch to
typed arrays.
The module is used in core in a few places so this commit makes the
public module private and replaces the public part with wrappers that
print deprecation notices.
R=@domenic @trevnorris
TBD: Deprecate src/smalloc.h as well? Probably a good thing but the header is used when building core and deprecation warnings would be annoying (although I guess it could be made conditional on NODE_WANT_INTERNALS.)