src: perf_hooks: fix wrong sized delete #16898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
c++
fhinkel
approved these changes
Nov 9, 2017
addaleax
approved these changes
Nov 9, 2017
|
I have no idea how Coverity tracks these things but is this maybe the reason for https://github.com/ofrobots/node/blob/59a012aeb976347d6975c82fb376b5db41da146c/src/node_perf.cc#L217 ? Also, out of curiousity, on which systems was this noticeable? |
cjihrig
approved these changes
Nov 9, 2017
|
@addaleax At Google we use sized deletes, which caught this once we upgraded to 8 LTS. The coverity comment you point you to is possibly related to this, but /cc @bnoordhuis in case there was another reason to add it. |
XadillaX
approved these changes
Nov 10, 2017
|
Not the same thing. |
ofrobots
force-pushed
the
perf-sized-delete
branch
from
59a012a
to
f8ec929
Compare
Depending on the allocator, existing code leaks memory. PR-URL: nodejs#16898 Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Khaidi Chu <i@2333.moe>
ofrobots
force-pushed
the
perf-sized-delete
branch
from
f8ec929
to
d37789d
Compare
|
Landed as d37789d. |
MylesBorins
pushed a commit
that referenced
this pull request
Dec 12, 2017
Depending on the allocator, existing code leaks memory. PR-URL: #16898 Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Khaidi Chu <i@2333.moe>
Merged
gibfahn
pushed a commit
that referenced
this pull request
Dec 19, 2017
Depending on the allocator, existing code leaks memory. PR-URL: #16898 Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Khaidi Chu <i@2333.moe>
Closed
gibfahn
pushed a commit
that referenced
this pull request
Dec 20, 2017
Depending on the allocator, existing code leaks memory. PR-URL: #16898 Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Khaidi Chu <i@2333.moe>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depending on the allocator, existing code leaks memory.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
src: perf_hooks
CI: https://ci.nodejs.org/job/node-test-pull-request/11318/