Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WS connection should not crash with JS bindings session #17085

Merged
merged 1 commit into from
Dec 12, 2017
Merged

WS connection should not crash with JS bindings session #17085

merged 1 commit into from
Dec 12, 2017

Commits on Dec 11, 2017

  1. inspector: Fix crash for WS connection 

    Attaching WS session will now include a roundtrip onto the main thread
to make sure there is no other session (e.g. JS bindings)

This change also required refactoring WS socket implementation to better
support scenarios like this.

Fixes: #16852
PR-URL: #17085
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
    @eugeneo
    Eugene Ostroukhov authored and eugeneo committed Dec 11, 2017
    Configuration menu
    Copy the full SHA
    73ad3f9 View commit details
    Browse the repository at this point in the history