Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: wrap callback in common.mustCall #17173

Closed
wants to merge 1 commit into from
Closed

test: wrap callback in common.mustCall #17173

wants to merge 1 commit into from

Conversation

suman-mitra
Copy link
Contributor

Adding common.mustCall to wrap the callback

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

My first contribution to node

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Nov 21, 2017
@mscdex mscdex added the cluster Issues and PRs related to the cluster subsystem. label Nov 21, 2017
@jasnell
Copy link
Member

jasnell commented Nov 21, 2017

This shouldn't need to wait the 48 hours to land once CI passes

@jasnell
Copy link
Member

jasnell commented Nov 21, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/11584/

jasnell pushed a commit that referenced this pull request Nov 21, 2017
@suman-mitra @jasnell
test: wrap callback in common.mustCall
a95d88c 
PR-URL: #17173
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@jasnell
Copy link
Member

jasnell commented Nov 21, 2017

Landed in a95d88c. Thank you and congrats on your first PR to core!

@jasnell jasnell closed this Nov 21, 2017
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
@suman-mitra @MylesBorins
test: wrap callback in common.mustCall
417e7d1 
PR-URL: #17173
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Dec 12, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Dec 19, 2017
@suman-mitra @MylesBorins
test: wrap callback in common.mustCall
5d488ee 
PR-URL: #17173
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
gibfahn pushed a commit that referenced this pull request Dec 19, 2017
@suman-mitra @gibfahn
test: wrap callback in common.mustCall
c58c191 
PR-URL: #17173
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@gibfahn gibfahn mentioned this pull request Dec 20, 2017
Closed
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
@suman-mitra @gibfahn
test: wrap callback in common.mustCall
27ee711 
PR-URL: #17173
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@gibfahn gibfahn mentioned this pull request Dec 20, 2017
Merged
@MylesBorins MylesBorins mentioned this pull request Dec 20, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@Trott Trott Trott approved these changes

@cjihrig cjihrig cjihrig approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

Assignees
No one assigned
Labels
cluster Issues and PRs related to the cluster subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@suman-mitra @jasnell @Trott @cjihrig @gireeshpunathil @mscdex @MylesBorins @gibfahn @nodejs-github-bot