Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: remove unused parameter #17184

Closed
wants to merge 1 commit into from
Closed

test: remove unused parameter #17184

wants to merge 1 commit into from

Conversation

fdescamps
Copy link
Contributor

@fdescamps fdescamps commented Nov 21, 2017 •
edited
Loading

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Nov 21, 2017
@benjamingr
Copy link
Member

benjamingr commented Nov 21, 2017 •
edited
Loading

Thanks for doing this!

@targos
Copy link
Member

targos commented Nov 21, 2017

@fdescamps the email address you used in git is not associated with your GitHub account. To make the link, you can go to this page: https://github.com/settings/emails

@targos
Copy link
Member

targos commented Nov 21, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/11576/

@fdescamps
Copy link
Contributor Author

It's ok now, thanks @targos

@mscdex mscdex added the readline Issues and PRs related to the built-in readline module. label Nov 21, 2017
jasnell
jasnell approved these changes Nov 21, 2017
View reviewed changes
Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn't need to wait the 48 hours to land once CI comes back green

jasnell pushed a commit that referenced this pull request Nov 21, 2017
@fdescamps @jasnell
test: remove unused parameter
ae6368d 
PR-URL: #17184
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell
Copy link
Member

jasnell commented Nov 21, 2017

Landed in ae6368d! Thank you and congrats on your first PR to core! :-)

@jasnell jasnell closed this Nov 21, 2017
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
@fdescamps @MylesBorins
test: remove unused parameter
a08bcae 
PR-URL: #17184
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Dec 12, 2017
Merged
gibfahn pushed a commit that referenced this pull request Dec 19, 2017
@fdescamps @gibfahn
test: remove unused parameter
475634b 
PR-URL: #17184
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@gibfahn gibfahn mentioned this pull request Dec 20, 2017
Closed
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
@fdescamps @gibfahn
test: remove unused parameter
71d554e 
PR-URL: #17184
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@gibfahn gibfahn mentioned this pull request Dec 20, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@benjamingr benjamingr benjamingr approved these changes

@targos targos targos approved these changes

@cjihrig cjihrig cjihrig approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

Assignees
No one assigned
Labels
readline Issues and PRs related to the built-in readline module. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@fdescamps @benjamingr @targos @jasnell @cjihrig @gireeshpunathil @mscdex @MylesBorins @gibfahn @nodejs-github-bot