doc: add ES Modules entry to who-to-cc #17205
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add ES Modules entry for who-to-cc. Resisted temptation to change it to "whom to CC". Did move async_hooks entry, though.
refack
approved these changes
Nov 22, 2017
|
LGTM, but maybe you should ping the subjects of this changes? |
Let's see if they all really actually want to be pinged for ES Modules stuff. I can see @jasnell and/or @Fishrock123 deciding that they'll opt out of this one.... |
|
Feel free to remove me from the list for es modules |
gireeshpunathil
approved these changes
Nov 22, 2017
lpinca
approved these changes
Nov 22, 2017
|
You can add me to the list. I also think an |
danbev
approved these changes
Nov 22, 2017
jasnell
approved these changes
Nov 24, 2017
maclover7
approved these changes
Nov 24, 2017
aqrln
approved these changes
Nov 25, 2017
|
Linter is green. Going to land... |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Nov 25, 2017
Add ES Modules entry for who-to-cc. Resisted temptation to change it to "whom to CC". Did move async_hooks entry, though. PR-URL: nodejs#17205 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
|
Landed in 73154c0. |
MylesBorins
pushed a commit
that referenced
this pull request
Dec 12, 2017
Add ES Modules entry for who-to-cc. Resisted temptation to change it to "whom to CC". Did move async_hooks entry, though. PR-URL: #17205 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 12, 2017
Add ES Modules entry for who-to-cc. Resisted temptation to change it to "whom to CC". Did move async_hooks entry, though. PR-URL: #17205 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
Merged
gibfahn
pushed a commit
that referenced
this pull request
Dec 19, 2017
Add ES Modules entry for who-to-cc. Resisted temptation to change it to "whom to CC". Did move async_hooks entry, though. PR-URL: #17205 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
Closed
gibfahn
pushed a commit
that referenced
this pull request
Dec 20, 2017
Add ES Modules entry for who-to-cc. Resisted temptation to change it to "whom to CC". Did move async_hooks entry, though. PR-URL: #17205 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ES Modules entry for who-to-cc. Resisted temptation to change it to
"whom to CC". Did add other minor fixes, though (whitespace and moving
async_hooks, removing unnecessary escaping).Checklist
Affected core subsystem(s)
doc