Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V8 6.1 backports #17354

Closed
wants to merge 3 commits into from
Closed

V8 6.1 backports #17354

wants to merge 3 commits into from

Commits on Nov 28, 2017

  1. test: flag known flake

    `test-inspector-async-hook-setup-at-signal` is also flaky on VS2017
    refack authored and MylesBorins committed Nov 28, 2017
    Configuration menu
    Copy the full SHA
    3668a82 View commit details
    Browse the repository at this point in the history

Commits on Nov 29, 2017

  1. deps: V8: cherry-pick cfc3404f from upstream

    Original commit message:
      [string] Fix regexp fast path in MaybeCallFunctionAtSymbol
    
      The regexp fast path in MaybeCallFunctionAtSymbol had an issue in which
      we'd call ToString after checking that the given {object} was a fast
      regexp and deciding to take the fast path. This is invalid since
      ToString() can call into user-controlled JS and may mutate {object}.
    
      There's no way to place the ToString call correctly in this instance:
      1 before BranchIfFastRegExp, it's a spec violation if we end up on the
        slow regexp path;
      2 the problem with the current location is already described above;
      3 and we can't place it into the fast-path regexp builtin (e.g.
        RegExpReplace) either due to the same reasons as 1.
    
      The solution in this CL is to restrict the fast path to string
      arguments only, i.e. cases where ToString would be a nop and can safely
      be skipped.
    
      Bug: chromium:782145
      Change-Id: Ifd35b3a9a6cf2e77c96cb860a8ec98eaec35aa85
      Reviewed-on: https://chromium-review.googlesource.com/758257
      Commit-Queue: Jakob Gruber <jgruber@chromium.org>
      Reviewed-by: Yang Guo <yangguo@chromium.org>
      Cr-Commit-Position: refs/heads/master@{nodejs#49213}
    
    Ref: v8/v8@cfc3404
    Ref: v8/v8@55a9807
    ofrobots committed Nov 29, 2017
    Configuration menu
    Copy the full SHA
    cc77b16 View commit details
    Browse the repository at this point in the history

Commits on Nov 30, 2017

  1. [SQUASH] add v8 version bump

    ofrobots committed Nov 30, 2017
    Configuration menu
    Copy the full SHA
    47095c8 View commit details
    Browse the repository at this point in the history