Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools,test: use Execute instead of check_output #17381

Merged
merged 1 commit into from
Nov 30, 2017
Merged

tools,test: use Execute instead of check_output #17381

merged 1 commit into from
Nov 30, 2017

Commits on Nov 30, 2017

  1. tools,test: use Execute instead of check_output 

    subprocess.check_output is a python2.7 only feature. Using Execute
allows keeping python2.6 compatibility

PR-URL: nodejs#17381
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
    @refack
    refack committed Nov 30, 2017
    Configuration menu
    Copy the full SHA
    fff3792 View commit details
    Browse the repository at this point in the history