Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v8.x] buffer: zero-fill buffer allocated with invalid content #17467

Closed
wants to merge 3 commits into from

Commits on Nov 28, 2017

  1. test: flag known flake

    `test-inspector-async-hook-setup-at-signal` is also flaky on VS2017
    Refael Ackermann authored and MylesBorins committed Nov 28, 2017
    Configuration menu
    Copy the full SHA
    3668a82 View commit details
    Browse the repository at this point in the history

Commits on Dec 5, 2017

  1. doc: warn against filling buffer with invalid data

    PR-URL: nodejs#17428
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
    Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    addaleax committed Dec 5, 2017
    Configuration menu
    Copy the full SHA
    59ee7a2 View commit details
    Browse the repository at this point in the history
  2. buffer: zero-fill buffer allocated with invalid content

    Zero-fill when `Buffer.alloc()` receives invalid fill data.
    
    A solution like nodejs#17427 which switches
    to throwing makes sense, but is likely a breaking change.
    
    This suggestion leaves the behaviour of `buffer.fill()` untouched,
    since any change to it would be a breaking change, and lets
    `Buffer.alloc()` check whether any filling took place or not.
    
    PR-URL: nodejs#17428
    Refs: nodejs#17427
    Refs: nodejs#17423
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
    Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    addaleax committed Dec 5, 2017
    Configuration menu
    Copy the full SHA
    29f6218 View commit details
    Browse the repository at this point in the history