doc: more assorted fixes #17519

Trott · 2017-12-07T05:51:14Z

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
documentation is changed or added
commit message follows commit guidelines

Affected core subsystem(s)

doc

mithunsasidharan · 2017-12-07T17:14:40Z

COLLABORATOR_GUIDE.md

@@ -130,7 +130,7 @@ can be fast-tracked and may be landed after a shorter delay:
 * Changes that fix regressions.

 When a pull request is deemed suitable to be fast-tracked, label it with
-`fast-track`. The pull request can be landed once 2 or more collaborators
+`fast-track`. The pull request can be landed once 2 or more Collaborators


Shouldn't it be collaborators instead of Collaborators ? Its not the first word in a new line but part of the line right ?

Collaborator is a title and it should be capitalized.

Should we be linting for capitalizing Collaborator(s) then?

Shouldn't it be collaborators instead of Collaborators ?

A case could be made for lower case or capitalizing. While I would prefer lower case myself, I am far more concerned with consistency. Since we capitalize it multiple times elsewhere in this and other documents, capitalizing it here normalizes things without a lot of needless churn.

mithunsasidharan · 2017-12-07T17:16:06Z

README.md

-Additionally, Current and LTS releases (not Nightlies) have the GPG
-detached signature of SHASUMS256.txt available as SHASUMS256.txt.sig.
-You can use `gpg` to verify that SHASUMS256.txt has not been tampered with.
+Current and LTS releases (but not Nightlies) also have the GPG detached


excluding Nightlies sounds more correct than but not Nightlies

"but not Nightlies" sounds better to me because the two preceding items do not include (or in any way reference) Nightlies so "excluding" doesn't make sense.

richardlau · 2017-12-07T19:12:53Z

README.md

@@ -149,8 +146,7 @@ Use a command such as this to import the keys:
 $ gpg --keyserver pool.sks-keyservers.net --recv-keys DD8F2338BAE7501E3DD5AC78C273792F7D83545D
 ```

-_(See the bottom of this README for a full script to import active
-release keys)_
+(See the bottom of this README for a full script to import active release keys.)


Maybe remove the parentheses as well?

@richardlau Yes, that's a good suggestion. Done!

* convert run-on sentence to a bulleted list * standardize capitalization in "Collaborators"

Use consistent typography and other minor changes to Verifying Binaries section.

Make text for Console constructor more precise.

Rewrite and edit somewhat confusing paragraph about inodes and AIX in fs.md.

Trott · 2017-12-07T21:45:50Z

CI: https://ci.nodejs.org/job/node-test-pull-request/11957/

* convert run-on sentence to a bulleted list * standardize capitalization in "Collaborators" PR-URL: nodejs#17519 Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

Use consistent typography and other minor changes to Verifying Binaries section. PR-URL: nodejs#17519 Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

Make text for Console constructor more precise. PR-URL: nodejs#17519 Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

Rewrite and edit somewhat confusing paragraph about inodes and AIX in fs.md. PR-URL: nodejs#17519 Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

Trott · 2017-12-08T19:31:40Z

Landed in 5b4a5c8, af5cfaf, c3a9970, and 25385ef.