test: use countdown in http-agent test #17537
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fedekau
changed the title
fedekau
force-pushed
the
add-countdown-to-http-agent-test
branch
from
ecb661b
to
48c0c96
Compare
test/parallel/test-http-agent.js
Outdated
| @@ -33,12 +34,13 @@ const server = http.Server(common.mustCall(function(req, res) { | |||
| }, (N * M))); // N * M = good requests (the errors will not be counted) | |||
|
|
|||
| function makeRequests(outCount, inCount, shouldFail) { | |||
| const countdown = new Countdown(1, common.mustCall(() => server.close())); | |||
There was a problem hiding this comment.
Limit of countdown can be outCount*inCount instead of 1.
test/parallel/test-http-agent.js
Outdated
| @@ -33,12 +34,13 @@ const server = http.Server(common.mustCall(function(req, res) { | |||
| }, (N * M))); // N * M = good requests (the errors will not be counted) | |||
|
|
|||
| function makeRequests(outCount, inCount, shouldFail) { | |||
| const countdown = new Countdown(1, common.mustCall(() => server.close())); | |||
| let responseCount = outCount * inCount; | |||
| let onRequest = common.mustNotCall(); // Temporary | |||
| const p = new Promise((resolve) => { | |||
| onRequest = common.mustCall((res) => { | |||
| if (--responseCount === 0) { | |||
There was a problem hiding this comment.
Can replace this whole if block with countdown.dec();
test/parallel/test-http-agent.js
Outdated
| @@ -33,12 +34,13 @@ const server = http.Server(common.mustCall(function(req, res) { | |||
| }, (N * M))); // N * M = good requests (the errors will not be counted) | |||
|
|
|||
| function makeRequests(outCount, inCount, shouldFail) { | |||
| const countdown = new Countdown(1, common.mustCall(() => server.close())); | |||
| let responseCount = outCount * inCount; | |||
There was a problem hiding this comment.
Can remove responseCount variable.
|
Thanks for contribution!!! Please, do use make lint/vcbuild lint before pr. |
|
@sreepurnajasti Thanks for the comments, I am pretty sure that I did run Do you think this would be ok ? ...
const countdown = new Countdown(
outCount * inCount,
common.mustCall(() => server.close())
);
let onRequest = common.mustNotCall(); // Temporary
const p = new Promise((resolve) => {
onRequest = common.mustCall((res) => {
if (countdown.dec() === 0) {
resolve();
}
if (!shouldFail)
res.resume();
}, outCount * inCount);
});
... |
|
That should work. You can also run |
fedekau
force-pushed
the
add-countdown-to-http-agent-test
branch
from
48c0c96
to
a03d533
Compare
|
Thanks @apapirovski, I have already run all tests and linter 😄 after amending the last commit |
|
@fedekau LGTM. Thanks!! |
apapirovski
approved these changes
Dec 9, 2017
|
@apapirovski Do you think that this failure is related to my change? To me seems like it is not, or is it? 🤔 |
|
@fedekau Completely unrelated, this PR is all good :) |
apapirovski
pushed a commit
that referenced
this pull request
Dec 10, 2017
PR-URL: #17537 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
|
Thanks @apapirovski and @sreepurnajasti I hope this is the first of many PRs 💪 |
MylesBorins
pushed a commit
that referenced
this pull request
Dec 12, 2017
PR-URL: #17537 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 12, 2017
PR-URL: #17537 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Merged
gibfahn
pushed a commit
that referenced
this pull request
Dec 20, 2017
PR-URL: #17537 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Closed
gibfahn
pushed a commit
that referenced
this pull request
Dec 20, 2017
PR-URL: #17537 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Merged
gibfahn
pushed a commit
that referenced
this pull request
Dec 20, 2017
PR-URL: #17537 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, this is my first PR to node!
I started by tackling one of the tests listed in #17169, in particular the
test/parallel/test-http-agent.jstest. Hopefully everything looks good to you, otherwise let me know what can be improved 😄Checklist
make -j4 testmake lint