repl: fix util.inspect() coloring regression #17565
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `Object.assign()` calls introduced in commit 90a4390 ("repl: show proxies as Proxy objects") mutated their first argument, causing the `{ colors: true }` option from the REPL to leak over into the global `util.inspect.defaultOptions` object. Refs: nodejs#16485 (comment)
addaleax
approved these changes
Dec 9, 2017
cjihrig
approved these changes
Dec 9, 2017
BridgeAR
approved these changes
Dec 9, 2017
TimothyGu
approved these changes
Dec 9, 2017
Fishrock123
approved these changes
Dec 10, 2017
lpinca
approved these changes
Dec 11, 2017
maclover7
added
the
author ready
|
Landed in 727339e |
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
Dec 12, 2017
The `Object.assign()` calls introduced in commit 90a4390 ("repl: show proxies as Proxy objects") mutated their first argument, causing the `{ colors: true }` option from the REPL to leak over into the global `util.inspect.defaultOptions` object. Refs: nodejs#16485 (comment) PR-URL: nodejs#17565 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
addaleax
removed
the
author ready
|
Setting don't land labels as this relies on a semver major change |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Object.assign()calls introduced in commit 90a4390 ("repl: showproxies as Proxy objects") mutated their first argument, causing the
{ colors: true }option from the REPL to leak over into the globalutil.inspect.defaultOptionsobject.Refs: #16485 (comment)
CI: https://ci.nodejs.org/job/node-test-pull-request/11995/