src: clean up argument assertions in node_file.cc #18192
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
bnoordhuis
approved these changes
Jan 17, 2018
src/node_file.cc
Outdated
| Local<Context> context = env->context(); | ||
| CHECK_GE(args.Length(), 2); | ||
|
|
||
| int argc = args.Length(); |
There was a problem hiding this comment.
const int argc = ... if you're caching it. .Length() is really just an inexpensive pointer load though.
cjihrig
approved these changes
Jan 17, 2018
jasnell
approved these changes
Jan 17, 2018
- Cache `args.Length()` - Use `value.As<T>()` to cast the arguments
joyeecheung
force-pushed
the
cleanup-fs
branch
from
6aebd6f
to
95d9201
Compare
|
Rebased and updated with @bnoordhuis's suggestion. |
|
Only one unrelated CI failure. Landed in e1c29f2, thanks! |
joyeecheung
added a commit
that referenced
this pull request
Jan 20, 2018
- Cache `args.Length()` - Use `value.As<T>()` to cast the arguments PR-URL: #18192 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
|
This does not land cleanly on v9.x, would someone be willing to do a backport? |
|
This is cleaning up the code mostly came from semver-major changes, so does not make too much sense to backport. |
MayaLekova
pushed a commit
to MayaLekova/node
that referenced
this pull request
May 8, 2018
- Cache `args.Length()` - Use `value.As<T>()` to cast the arguments PR-URL: nodejs#18192 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
args.Length()value.As<T>()to cast the argumentsChecklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
fs