Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed broken links to Style Guide and CPP Style Guide #18683

Closed
wants to merge 1 commit into from
Closed

Fixed broken links to Style Guide and CPP Style Guide #18683

wants to merge 1 commit into from

Conversation

justin0022
Copy link
Contributor

I've fixed the broken links in pull-requests.md, but I'm not convinced that the Style Guides are located in the right places to begin with. Thoughts?

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Feb 9, 2018
@vsemozhetbyt vsemozhetbyt added the fast-track PRs that do not need to wait for 48 hours to land. label Feb 9, 2018
joyeecheung
joyeecheung approved these changes Feb 9, 2018
View reviewed changes
Copy link
Member

@joyeecheung joyeecheung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah...the style guide should probably go into doc/guides, although that can be resolved/discussed in another PR

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 9, 2018
@BridgeAR
Copy link
Member

BridgeAR commented Feb 9, 2018

CI https://ci.nodejs.org/job/node-test-commit-light/246/

vsemozhetbyt pushed a commit that referenced this pull request Feb 10, 2018
@justin0022 @vsemozhetbyt
doc: fix links to Style Guide and CPP Style Guide
37c88f0 
PR-URL: #18683
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@vsemozhetbyt
Copy link
Contributor

Landed in 37c88f0

@vsemozhetbyt vsemozhetbyt mentioned this pull request Feb 10, 2018
Closed
@vsemozhetbyt
Copy link
Contributor

Not closing for now to investigate nodejs/node-core-utils#170

@BridgeAR
Copy link
Member

Seems like the issue gets addressed. I am closing this therefore as there is nothing more to do.

@BridgeAR BridgeAR closed this Feb 10, 2018
MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
@justin0022 @MylesBorins
doc: fix links to Style Guide and CPP Style Guide
ba05498 
PR-URL: #18683
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
@justin0022 @MylesBorins
doc: fix links to Style Guide and CPP Style Guide
86c1ffb 
PR-URL: #18683
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
@justin0022 @MylesBorins
doc: fix links to Style Guide and CPP Style Guide
b192190 
PR-URL: #18683
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Feb 21, 2018
Merged
MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
@justin0022 @MylesBorins
doc: fix links to Style Guide and CPP Style Guide
4981e98 
PR-URL: #18683
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
gibfahn pushed a commit that referenced this pull request Apr 13, 2018
@justin0022 @gibfahn
doc: fix links to Style Guide and CPP Style Guide
d30c353 
PR-URL: #18683
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@MylesBorins MylesBorins mentioned this pull request May 2, 2018
Merged
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
@justin0022 @MayaLekova
doc: fix links to Style Guide and CPP Style Guide
d8eb6ac 
PR-URL: nodejs#18683
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This was referenced Mar 7, 2020
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@cjihrig cjihrig cjihrig approved these changes

@joyeecheung joyeecheung joyeecheung approved these changes

@richardlau richardlau richardlau approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@vsemozhetbyt vsemozhetbyt vsemozhetbyt approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@justin0022 @BridgeAR @vsemozhetbyt @jasnell @cjihrig @joyeecheung @richardlau @gibfahn @nodejs-github-bot