Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: update REPLACEME tag to correct version #18979

Conversation

prog1dev
Copy link
Contributor

@prog1dev prog1dev commented Feb 24, 2018

Looks like @evanlucas forgot to update one REPLACEME tag in assert.md doc on 9.5.0 release
Here is a change in 9.5.0 change logs

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

@nodejs-github-bot nodejs-github-bot added assert Issues and PRs related to the assert subsystem. doc Issues and PRs related to the documentations. labels Feb 24, 2018
@prog1dev prog1dev closed this Feb 24, 2018
@prog1dev prog1dev reopened this Feb 24, 2018
@prog1dev
Copy link
Contributor Author

But I cant find this change in v9.6.0-proposal branch. Am I missing something?

@prog1dev prog1dev closed this Feb 24, 2018
@prog1dev prog1dev deleted the doc/update_replaceme_tag_to_correct_version branch February 24, 2018 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assert Issues and PRs related to the assert subsystem. doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants