Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test : refactor parallel/test-tls-async-cb-after-socket-end #18985

Conversation

juggernaut451
Copy link
Contributor

this replaces the function with arrow function, callback by common.mustCall
and added the description

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Feb 25, 2018
const options = {
secureOptions: SSL_OP_NO_TICKET,
key: fixtures.readSync('test_key.pem'),
cert: fixtures.readSync('test_cert.pem')
};

const server = tls.createServer(options, function(c) {
});
const server = tls.createServer(options, common.mustCall((c) => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the callback is empty it can be omitted from common.mustCall().

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant that this could be just common.mustCall().

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry wrong interpreted

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change made :)

const options = {
secureOptions: SSL_OP_NO_TICKET,
key: fixtures.readSync('test_key.pem'),
cert: fixtures.readSync('test_cert.pem')
};

const server = tls.createServer(options, function(c) {
const server = tls.createServer(options, (c) => {
});
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just so it is not overlooked: #18985 (comment)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixing it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed :) Thanks for pointing out


function next() {
if (!client || !sessionCb)
return;


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: it would be great to remove this line again.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed :)

Copy link
Contributor

@davisokoth davisokoth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fhinkel
Copy link
Member

fhinkel commented Mar 15, 2018

LGTM with @davisokoth 's comment about squashing.

CI: https://ci.nodejs.org/job/node-test-pull-request/13696/

@juggernaut451 juggernaut451 force-pushed the refactorTestTlsAsyncCbAfterSocketEnd branch from c4ce57a to 855826f Compare March 17, 2018 19:05
@juggernaut451
Copy link
Contributor Author

change made :)

@trivikr
Copy link
Member

trivikr commented Mar 26, 2018

@trivikr
Copy link
Member

trivikr commented Mar 26, 2018

CI is failing for node-test-commit-linux in debian8-x86/debian8-64
Details: https://ci.nodejs.org/job/node-test-commit-linux/17355/

@trivikr
Copy link
Member

trivikr commented Mar 26, 2018

node-test-commit-linux was rerun, failed again for debian8-64 https://ci.nodejs.org/job/node-test-commit-linux/17356/
It might be a flaky test

@BridgeAR
Copy link
Member

BridgeAR commented Apr 9, 2018

Landed in d1156da

@BridgeAR BridgeAR closed this Apr 9, 2018
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Apr 9, 2018
PR-URL: nodejs#18985
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
targos pushed a commit that referenced this pull request Apr 12, 2018
PR-URL: #18985
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants