doc: improve text in async_hooks.md #19312
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove unnecessary *Note:* designations. * Various small edits for tone, punctuation, etc.
nodejs-github-bot
added
async_hooks
vsemozhetbyt
approved these changes
Mar 13, 2018
Trott
added
the
author ready
cjihrig
approved these changes
Mar 13, 2018
| `0` means it's being executed from C++, with no JavaScript stack above it). | ||
| With only that information, it would be impossible to link resources together in | ||
| connection is made, the `TCPWrap` instance is immediately constructed. This | ||
| happens outside of any JavaScript stack. (An `executionAsyncId()` of `0` means |
There was a problem hiding this comment.
The full sentence in parens followed by a period outside of the parens looks a little bit odd.
jasnell
approved these changes
Mar 14, 2018
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Mar 15, 2018
* Remove unnecessary *Note:* designations. * Various small edits for tone, punctuation, etc. PR-URL: nodejs#19312 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
|
Landed in 8d336dd |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist