Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net: emit error on invalid address family #19415

Merged
merged 1 commit into from
Mar 19, 2018
Merged

net: emit error on invalid address family #19415

merged 1 commit into from
Mar 19, 2018

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Mar 17, 2018

This commit adds proper error handling to net.connect() when a custom lookup() function returns an invalid address family.

Fixes: #19407

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added errors Issues and PRs related to JavaScript errors originated in Node.js core. net Issues and PRs related to the net subsystem. labels Mar 17, 2018
richardlau
richardlau reviewed Mar 17, 2018
View reviewed changes
test/parallel/test-net-options-lookup.js Outdated
cb(null, '127.0.0.1', 100);
});

s.on('error', common.mustCall((err) => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

common.expectsError?

@targos targos mentioned this pull request Mar 17, 2018
Closed
4 tasks
@cjihrig
Copy link
Contributor Author

cjihrig commented Mar 19, 2018

Updated to use common.expectsError(). CI: https://ci.nodejs.org/job/node-test-pull-request/13743/

@cjihrig
net: emit error on invalid address family
7c73cd4 
This commit adds proper error handling to net.connect() when
a custom lookup() function returns an invalid address family.

PR-URL: nodejs#19415
Fixes: nodejs#19407
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: James M Snell <jasnell@gmail.com>
@cjihrig cjihrig merged commit 7c73cd4 into nodejs:master Mar 19, 2018
@cjihrig cjihrig deleted the 19407 branch March 19, 2018 18:51
@MylesBorins
Copy link
Contributor

Should this be backported to v9.x-staging? If yes please follow the guide and raise a backport PR, if not let me know or add the dont-land-on label.

BridgeAR pushed a commit to BridgeAR/node that referenced this pull request May 1, 2018
@cjihrig @BridgeAR
net: emit error on invalid address family
a37beba 
This commit adds proper error handling to net.connect() when
a custom lookup() function returns an invalid address family.

PR-URL: nodejs#19415
Fixes: nodejs#19407
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlau richardlau richardlau left review comments

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

@santigimeno santigimeno santigimeno approved these changes

@targos targos targos approved these changes

@XadillaX XadillaX XadillaX approved these changes

@joyeecheung joyeecheung joyeecheung approved these changes

Assignees
No one assigned
Labels
errors Issues and PRs related to JavaScript errors originated in Node.js core. net Issues and PRs related to the net subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@cjihrig @MylesBorins @jasnell @addaleax @santigimeno @targos @XadillaX @joyeecheung @richardlau @nodejs-github-bot