Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: ensure that SetImmediate()s have HandleScopes #19470

Closed

Conversation

addaleax
Copy link
Member

  • src: simplify http2 perf tracking code

    Use unique_ptrs and use the resulting simplification to
    reduce indentation in these functions.

  • src: ensure that SetImmediate()s have HandleScopes

    Make sure that all native SetImmediate() functions have
    HandleScopes if they create handles.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

CI: https://ci.nodejs.org/job/node-test-commit/17015/

Use `unique_ptr`s and use the resulting simplification to
reduce indentation in these functions.
Make sure that all native `SetImmediate()` functions have
`HandleScope`s if they create handles.
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. labels Mar 20, 2018
@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 20, 2018
@addaleax
Copy link
Member Author

New CI, to be sure: https://ci.nodejs.org/job/node-test-commit/17120/

@addaleax
Copy link
Member Author

Landed in e8c2917, 2d94f77

@addaleax addaleax closed this Mar 25, 2018
@addaleax addaleax deleted the http2-setimmediate-handle-scope branch March 25, 2018 16:46
addaleax added a commit that referenced this pull request Mar 25, 2018
Use `unique_ptr`s and use the resulting simplification to
reduce indentation in these functions.

PR-URL: #19470
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
addaleax added a commit that referenced this pull request Mar 25, 2018
Make sure that all native `SetImmediate()` functions have
`HandleScope`s if they create handles.

PR-URL: #19470
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@targos targos added dont-land-on-v9.x and removed author ready PRs that have at least one approval, no pending requests for changes, and a CI started. dont-land-on-v9.x labels Apr 2, 2018
addaleax added a commit that referenced this pull request Jun 29, 2018
Use `unique_ptr`s and use the resulting simplification to
reduce indentation in these functions.

PR-URL: #19470
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@MylesBorins MylesBorins mentioned this pull request Jul 9, 2018
rvagg pushed a commit that referenced this pull request Aug 16, 2018
Use `unique_ptr`s and use the resulting simplification to
reduce indentation in these functions.

PR-URL: #19470
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants