test: fix incorrect assumptions on the user uid and gid #19554
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a invalidArgTypeErrorCount variable to adjust the number of expected errors if the uid and gid options cannot be properly validated. Fixes: nodejs#19371
trivikr
added
the
child_process
gireeshpunathil
approved these changes
Mar 27, 2018
|
ping @nodejs/collaborators for a couple of pair of eyes more! |
Leko
approved these changes
Mar 29, 2018
gireeshpunathil
added
the
author ready
jasnell
approved these changes
Mar 29, 2018
gireeshpunathil
pushed a commit
that referenced
this pull request
Mar 29, 2018
Add a invalidArgTypeErrorCount variable to adjust the number of expected errors if the uid and gid options cannot be properly validated. Fixes: #19371 PR-URL: #19554 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Shingo Inoue <leko.noor@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
|
Landed in 42c7402 , thanks for the contribution! |
This was referenced Mar 29, 2018
targos
added
backport-requested-v9.x
and removed
author ready
|
Should this be backported to |
|
the changes pertinent to this PR is not relevant for older release lines. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a invalidArgTypeErrorCount variable to adjust the number of expected
errors if the uid and gid options cannot be properly validated.
Fixes: #19371
Has been tested as working on Ubuntu 14.04 LTS. Requires testing still in Windows with container/non-container environment still.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes